Bug 2102222

This bug was initially created as a copy of Bug #2100395

Description of problem:

Upon rpcbind package update the following command is issued from rpm scriptlet:
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------
systemctl try-restart rpcbind.service rpcbind.socket
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------

This ends up having the rpcbind.socket fail to start, because rpcbind.service is already active and also hijacked the sockets.

The journal shows some kind of race condition between the service and the socket:
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------
# journalctl -b -u rpcbind.service -u rpcbind.socket -o short-precise
-- Logs begin at Thu 2022-06-23 10:59:56 CEST, end at Thu 2022-06-23 11:01:01 CEST. --
Jun 23 11:00:00.387955 vm-rhel8 systemd[1]: Starting RPC Bind...
Jun 23 11:00:00.454849 vm-rhel8 systemd[1]: Started RPC Bind.
Jun 23 11:00:35.378595 vm-rhel8 systemd[1]: Stopping RPC Bind...
Jun 23 11:00:35.380285 vm-rhel8 systemd[1]: rpcbind.service: Succeeded.
Jun 23 11:00:35.380591 vm-rhel8 systemd[1]: Stopped RPC Bind.

Jun 23 11:00:35.381691 vm-rhel8 systemd[1]: Starting RPC Bind...

--> This is rpcbind.service restart

Jun 23 11:00:35.384161 vm-rhel8 systemd[1]: rpcbind.socket: Succeeded.
Jun 23 11:00:35.384504 vm-rhel8 systemd[1]: Closed RPCbind Server Activation Socket.
Jun 23 11:00:35.384525 vm-rhel8 systemd[1]: Stopping RPCbind Server Activation Socket.

--> This is rpcbind.socket restart, only the stop happens due to rpcbind.service hijacking the sockets

Jun 23 11:00:35.384595 vm-rhel8 systemd[1]: rpcbind.socket: Socket service rpcbind.service already active, refusing.
Jun 23 11:00:35.384618 vm-rhel8 systemd[1]: Failed to listen on RPCbind Server Activation Socket.
Jun 23 11:00:35.384656 vm-rhel8 systemd[1]: Dependency failed for RPC Bind.
Jun 23 11:00:35.384673 vm-rhel8 systemd[1]: rpcbind.service: Job rpcbind.service/start failed with result 'dependency>

# netstat -anlp | egrep -w "rpcbind|111"
tcp        0      0 0.0.0.0:111             0.0.0.0:*               LISTEN      1559/rpcbind        
tcp6       0      0 :::111                  :::*                    LISTEN      1559/rpcbind        
udp        0      0 0.0.0.0:111             0.0.0.0:*                           1559/rpcbind        
udp6       0      0 :::111                  :::*                                1559/rpcbind        
unix  2      [ ACC ]     STREAM     LISTENING     20232    1559/rpcbind         /run/rpcbind.sock

--> everything held by "rpcbind" instead of "systemd"
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------

Interestingly, when stracing *systemd*, I'm not able to reproduce, which seems to indicate there is some race.

Version-Release number of selected component (if applicable):

Up to rpcbind-1.2.5-8.el8.x86_64 included

How reproducible:

Always

Steps to Reproduce:
1. Execute "systemctl try-restart rpcbind.service rpcbind.socket"

Actual results:

Job for rpcbind.socket failed.
See "systemctl status rpcbind.socket" and "journalctl -xe" for details.
A dependency job for rpcbind.service failed. See 'journalctl -xe' for details.

Expected results:

No error