Bug 2102571

Summary: Upgrade [OSP16.2 -> OSP17.1] Export the tripleo-STACK-baremetal-deployment.yaml fully automated
Product: Red Hat OpenStack Reporter: Juan Badia Payno <jbadiapa>
Component: python-tripleoclientAssignee: Harald Jensås <hjensas>
Status: CLOSED ERRATA QA Contact: James E. LaBarre <jlabarre>
Severity: medium Docs Contact:
Priority: high    
Version: 17.1 (Wallaby)CC: drosenfe, eshames, hjensas, jpretori, jslagle, mariel, mburns, pweeks, sbaker
Target Milestone: z1Keywords: Reopened, TestOnly, Triaged
Target Release: 17.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-tripleoclient-16.5.1-1.20230331004518.50884d7.el8ost Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-05-22 21:04:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Juan Badia Payno 2022-06-30 09:00:00 UTC
Currently the FFU process from osp16.2 to osp17.0, the exported file tripleo-STACK-baremetal-deployment.yaml needs some manual configuration. Some examples:
 The resource_class is not added to the ROLE.
 The network.template is set to null.
 The instances.name is configure by server name instead of UUID.

Comment 8 Lukas Svaty 2023-06-16 08:13:29 UTC
Bulk moving target milestone to GA after the release of Beta on 14th June '23.

Comment 10 James E. LaBarre 2023-07-18 16:22:28 UTC
Upstream changes not incorporated into latest compose (RHOS-17.1-RHEL-9-20230712.n.1)

Comment 11 James E. LaBarre 2023-07-18 16:59:14 UTC
Need to verify if these edits should have been incorporated directly, or do they get brought in via an upgrade process?  We don't have upgrade tests in our  jobs so I can't determine that on my own.

Comment 12 David Rosenfeld 2023-07-18 18:03:07 UTC
You could work with your DFG on a procedure. Here is my opinion. There are eleven commits for this BZ, but some are duplicates and at least one is fixing a broken commit. You can verify most of it just by looking at deployments:

The roles file is optional(verifies commit 848121):

openstack overcloud node extract provisioned --help
optional arguments:
 --roles-file ROLES_FILE, -r ROLES_FILE


The convert_heat_nic_config_to_ansible_j2.py is executable(verifies commit(848123):

[stack@undercloud-0 /]$ ls -l ./usr/share/openstack-tripleo-heat-templates/tools/convert_heat_nic_config_to_ansible_j2.py
-rwxr-xr-x. 1 root root 21050 Jul  6 10:08 ./usr/share/openstack-tripleo-heat-templates/tools/convert_heat_nic_config_to_ansible_j2.py


Look at a baremetal_deploy.yml for a Phase 3 upgrades job. Ex: http://rhos-ci-logs.lab.eng.tlv2.redhat.com/logs/rcj/DFG-upgrades-ffu-17.1-from-16.2-passed_phase2-3cont_3db_3msg_2net_3hci-ipv6-ovs_dvr/81/undercloud-0/home/stack/tripleo-qe-Cloud-0-baremetal-deployment.yaml.gz

It contains: 
WARNING: Network config for role ControllerOpenstack was automatically converted from Heat template(verifies commit 828019)

resource_class: controller  (verifies commit 848313 and 849216)

name: 2d42ae1d-beb0-4bb8-bc2e-b2b2bddaf7d9 (verifies commit 848447, 872291, 878850)

Those along with seeing a successful Phase 3 upgrades job is enough to verify, but is your call.

Comment 14 James E. LaBarre 2023-07-25 18:30:41 UTC
bumping to z1

Comment 17 James E. LaBarre 2023-09-07 17:35:23 UTC
Confirmed that resource_class is now being configured for instances, nic_config template is being set for each role, and instances are using node UUID rather than node_name for the tripleo-<stack>-baremetal-deployment.yaml file, where <stack> is the name for the cloud being configured and upgraded.

Checked against DFG-upgrades-ffu-17.1-from-16.2-passed_phase2-3cont_3hci-ipv4-ovs_dvr (compose RHOS-17.1-RHEL-9-20230831.n.1)

Comment 18 Lon Hohberger 2023-09-07 19:57:55 UTC
According to our records, this should be resolved by python-tripleoclient-16.5.1-1.20230505004752.el8ost.  This build is available now.

Comment 29 errata-xmlrpc 2024-05-22 21:04:06 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform 17.1.3 bug fix and enhancement advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2024:2742