Bug 2102663

Summary:	'pcs resource restart' fails with a traceback
Product:	Red Hat Enterprise Linux 9	Reporter:	Tomas Jelinek <tojeline>
Component:	pcs	Assignee:	Tomas Jelinek <tojeline>
Status:	CLOSED ERRATA	QA Contact:	cluster-qe <cluster-qe>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	9.1	CC:	cluster-maint, idevat, mlisik, mmazoure, mpospisi, nhostako, omular, svalasti, tojeline
Target Milestone:	rc	Keywords:	EasyFix, Regression, Triaged
Target Release:	9.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	pcs-0.11.3-2.el9	Doc Type:	No Doc Update
Doc Text:	the affected packages have not been released	Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-11-15 09:49:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tomas Jelinek 2022-06-30 12:19:51 UTC

Description of problem:
'pcs resource restart' fails with a traceback


Version-Release number of selected component (if applicable):
pcs-0.11.2-1.el9


How reproducible:
always, easily


Steps to Reproduce:
run 'pcs resource restart' for any existing resource


Actual results:
pcs fails with a traceback


Expected results:
pcs restarts the specified resource


Additional info:
the affected packages have not been released

Comment 2 Tomas Jelinek 2022-07-01 07:35:22 UTC

Upstream patch: https://github.com/ClusterLabs/pcs/commit/08a62b6e84db56cc3871c81826a420e22f726a65

see comment 0 for a test / reproducer

Comment 3 Miroslav Lisik 2022-07-15 14:50:01 UTC

DevTestResults:

[root@r90-node-01 ~]# rpm -q pcs
pcs-0.11.3-2.el9.x86_64

[root@r90-node-01 ~]# pcs resource restart d1
d1 successfully restarted

Comment 8 svalasti 2022-07-26 09:16:34 UTC

### BEFORE

[root@virt-044 ~]# rpm -q pcs
pcs-0.11.2-1.el9.x86_64


1.) 'Dummy' resource

[root@virt-044 ~]# pcs resource status | grep "d1"
  * d1	(ocf:heartbeat:Dummy):	 Started virt-044

[root@virt-044 ~]# pcs resource restart d1
Traceback (most recent call last):
  File "/usr/sbin/pcs", line 33, in <module>
    sys.exit(load_entry_point('pcs===0.11.2.44-9da7', 'console_scripts', 'pcs')())
  File "/usr/lib/python3.9/site-packages/pcs/app.py", line 273, in main
    routing.create_router(cmd_map, [])(
  File "/usr/lib/python3.9/site-packages/pcs/cli/common/routing.py", line 33, in _router
    return cmd_map[sub_cmd](lib, argv_next, modifiers)
  File "/usr/lib/python3.9/site-packages/pcs/cli/common/routing.py", line 33, in _router
    return cmd_map[sub_cmd](lib, argv_next, modifiers)
  File "/usr/lib/python3.9/site-packages/pcs/resource.py", line 2603, in resource_restart
    _check_is_not_stonith(lib, [argv[0]])
UnboundLocalError: local variable 'lib' referenced before assignment

[root@virt-044 ~]# echo $?
1


2.) Clone

[root@virt-044 ~]# pcs status | grep "d1" -A 1
  * Clone Set: d1-clone [d1]:
    * Started: [ virt-044 virt-045 ]

[root@virt-044 ~]# pcs resource restart d1-clone
Traceback (most recent call last):
  File "/usr/sbin/pcs", line 33, in <module>
    sys.exit(load_entry_point('pcs===0.11.2.44-9da7', 'console_scripts', 'pcs')())
  File "/usr/lib/python3.9/site-packages/pcs/app.py", line 273, in main
    routing.create_router(cmd_map, [])(
  File "/usr/lib/python3.9/site-packages/pcs/cli/common/routing.py", line 33, in _router
    return cmd_map[sub_cmd](lib, argv_next, modifiers)
  File "/usr/lib/python3.9/site-packages/pcs/cli/common/routing.py", line 33, in _router
    return cmd_map[sub_cmd](lib, argv_next, modifiers)
  File "/usr/lib/python3.9/site-packages/pcs/resource.py", line 2603, in resource_restart
    _check_is_not_stonith(lib, [argv[0]])
UnboundLocalError: local variable 'lib' referenced before assignment

[root@virt-044 ~]# echo $?
1


3.) Promotable clone

[root@virt-044 ~]# pcs status | grep "s1" -A 2
  * Clone Set: s1-clone [s1] (promotable):
    * Promoted: [ virt-044 ]
    * Unpromoted: [ virt-045 ]

[root@virt-044 ~]# pcs resource restart s1-clone
Traceback (most recent call last):
  File "/usr/sbin/pcs", line 33, in <module>
    sys.exit(load_entry_point('pcs===0.11.2.44-9da7', 'console_scripts', 'pcs')())
  File "/usr/lib/python3.9/site-packages/pcs/app.py", line 273, in main
    routing.create_router(cmd_map, [])(
  File "/usr/lib/python3.9/site-packages/pcs/cli/common/routing.py", line 33, in _router
    return cmd_map[sub_cmd](lib, argv_next, modifiers)
  File "/usr/lib/python3.9/site-packages/pcs/cli/common/routing.py", line 33, in _router
    return cmd_map[sub_cmd](lib, argv_next, modifiers)
  File "/usr/lib/python3.9/site-packages/pcs/resource.py", line 2603, in resource_restart
    _check_is_not_stonith(lib, [argv[0]])
UnboundLocalError: local variable 'lib' referenced before assignment

[root@virt-044 ~]# echo $?
1


4.) Group

[root@virt-044 ~]# pcs status | grep "dg" -A 2
  * Resource Group: dg:
    * d1	(ocf:heartbeat:Dummy):	 Started virt-044
    * d2	(ocf:heartbeat:Dummy):	 Started virt-044

[root@virt-044 ~]# pcs resource restart dg
Traceback (most recent call last):
  File "/usr/sbin/pcs", line 33, in <module>
    sys.exit(load_entry_point('pcs===0.11.2.44-9da7', 'console_scripts', 'pcs')())
  File "/usr/lib/python3.9/site-packages/pcs/app.py", line 273, in main
    routing.create_router(cmd_map, [])(
  File "/usr/lib/python3.9/site-packages/pcs/cli/common/routing.py", line 33, in _router
    return cmd_map[sub_cmd](lib, argv_next, modifiers)
  File "/usr/lib/python3.9/site-packages/pcs/cli/common/routing.py", line 33, in _router
    return cmd_map[sub_cmd](lib, argv_next, modifiers)
  File "/usr/lib/python3.9/site-packages/pcs/resource.py", line 2603, in resource_restart
    _check_is_not_stonith(lib, [argv[0]])
UnboundLocalError: local variable 'lib' referenced before assignment

[root@virt-044 ~]# echo $?
1


## AFTER

[root@virt-044 ~]# rpm -q pcs
pcs-0.11.3-2.el9.x86_64


1.) 'Dummy' resource

[root@virt-044 ~]# pcs resource status | grep "d1"
  * d1	(ocf:heartbeat:Dummy):	 Started virt-044

[root@virt-044 ~]# pcs resource restart d1
d1 successfully restarted

[root@virt-044 ~]# echo $?
0

> OK


2.) Clone

[root@virt-044 ~]# pcs status | grep "d1" -A 1
  * Clone Set: d1-clone [d1]:
    * Started: [ virt-044 virt-045 ]


A.) Restart on all cluster nodes

[root@virt-044 ~]# pcs resource restart d1-clone
d1-clone successfully restarted

[root@virt-044 ~]# echo $?
0

> OK.


B.) Restart on specified node

[root@virt-044 ~]# pcs resource restart d1-clone virt-045
d1-clone successfully restarted

[root@virt-044 ~]# echo $?
0

> OK.


3.) Promotable clone

[root@virt-044 ~]# pcs status | grep "s1" -A 2
  * Clone Set: s1-clone [s1] (promotable):
    * Promoted: [ virt-044 ]
    * Unpromoted: [ virt-045 ]


A.) Restart on all cluster nodes

[root@virt-044 ~]# pcs resource restart s1-clone
s1-clone successfully restarted

[root@virt-044 ~]# echo $?
0

> OK


B.) Restart promoted

[root@virt-044 ~]# pcs resource restart s1-clone virt-044
s1-clone successfully restarted

[root@virt-044 ~]# echo $?
0

> OK.


C.) Restart unpromoted

[root@virt-044 ~]# pcs resource restart s1-clone virt-045
s1-clone successfully restarted

[root@virt-044 ~]# echo $?
0

> OK.


4.) Group

[root@virt-044 ~]# pcs status | grep "dg" -A 2
  * Resource Group: dg:
    * d1	(ocf:heartbeat:Dummy):	 Started virt-044
    * d2	(ocf:heartbeat:Dummy):	 Started virt-044


A.) Restarting the group 

[root@virt-044 ~]# pcs resource restart dg
dg successfully restarted

[root@virt-044 ~]# echo $?
0

> OK


B.) Restarting resource in group

[root@virt-044 ~]# pcs resource restart d2
d2 successfully restarted

[root@virt-044 ~]# echo $?
0

> OK.

Comment 10 errata-xmlrpc 2022-11-15 09:49:31 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: pcs security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:7935