Bug 2102681

Summary: Workloads -> Deployments -> Edit update strategy: 'greater than pod' translation miss
Product: OpenShift Container Platform Reporter: Krishna Babu K <kkrothap>
Component: Management ConsoleAssignee: Pavel Kratochvil <pakratoc>
Status: CLOSED DEFERRED QA Contact: Yadan Pei <yapei>
Severity: low Docs Contact:
Priority: low    
Version: 4.11CC: jhadvig, kkrothap, vlaad, yapei
Target Milestone: ---Keywords: i18n, Translation
Target Release: 4.12.z   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-03-09 01:23:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Translation missing for 'greater than pod' none

Description Krishna Babu K 2022-06-30 12:40:39 UTC
Created attachment 1893656 [details]
Translation missing for 'greater than pod'

Description of problem:
  Navigation: 
             Workloads -> Deployments -> Edit update strategy
             'greater than pod' is in English

Version-Release number of selected component (if applicable):
4.11.0-0.nightly-2022-06-23-044003

How reproducible:
Always

Steps to Reproduce:
1.
2.
3.

Actual results:
Translation missing

Expected results:
Translation should appear

Additional info:

Comment 1 Krishna Babu K 2022-06-30 12:49:35 UTC
 Translations seems present for this at

    4.11/console/frontend/public/locales/zh/public.json:  "greater than pod_0": "大于 pod",
    4.11/console/frontend/public/locales/zh/public.json:  "{{maxSurge}} greater than {{count}} pod_0": "{{maxSurge}} 大于 {{count}} 个 pod",

Should it be changed to "{{maxSurge}} {{count}} greater than pod_0"  ?

Comment 3 xiangyli 2022-09-08 10:29:26 UTC
Since the payload could not be found, so I checked on this payload
4.11.0-0.nightly-2022-09-06-225330
and the `greater than pod` is still in English no matter what language you choose in User preferences.

Comment 4 Pavel Kratochvil 2022-09-08 15:20:13 UTC
(In reply to Krishna Babu K from comment #1)
>  Translations seems present for this at
> 
>     4.11/console/frontend/public/locales/zh/public.json:  "greater than
> pod_0": "大于 pod",
>     4.11/console/frontend/public/locales/zh/public.json:  "{{maxSurge}}
> greater than {{count}} pod_0": "{{maxSurge}} 大于 {{count}} 个 pod",
> 
> Should it be changed to "{{maxSurge}} {{count}} greater than pod_0"  ?

Not sure. Word order may differ from language to language. Can anyone confirm?

Comment 5 Pavel Kratochvil 2022-09-08 15:23:40 UTC
(In reply to xiangyli from comment #3)
> Since the payload could not be found, so I checked on this payload
> 4.11.0-0.nightly-2022-09-06-225330
> and the `greater than pod` is still in English no matter what language you
> choose in User preferences.

I just added the translation to ja, ko locales as well(the same issue with trailing '_0'). I can confirm it works on 4.11.0-0.nightly-2022-09-06-225330.

Comment 6 Pavel Kratochvil 2022-09-08 15:24:57 UTC
(In reply to xiangyli from comment #3)
> Since the payload could not be found, so I checked on this payload
> 4.11.0-0.nightly-2022-09-06-225330
> and the `greater than pod` is still in English no matter what language you
> choose in User preferences.

Link to the mentioned PR(ja, ko locales): https://github.com/openshift/console/pull/11865

Comment 7 Yadan Pei 2022-09-09 05:44:20 UTC
@xiangyli  when verifying the bugs, please do confirm

1) what version the issue will be fixed
2) what version are you checking, does it already include fix PR or not

moving back to ON_QA, please check against correct payload

Comment 8 xiangyli 2022-09-09 07:53:17 UTC
1) The issue will be fixed on master branch, which currently is 4.12
2) Checked on 4.12.0-0.nightly-2022-09-08-114806, the `greater than pod` is still not translated at the time

Comment 10 Krishna Babu K 2022-12-21 15:08:16 UTC
Checked on 4.12.0-rc.5, "greater than pod" not translated.

Comment 11 Shiftzilla 2023-03-09 01:23:01 UTC
OpenShift has moved to Jira for its defect tracking! This bug can now be found in the OCPBUGS project in Jira.

https://issues.redhat.com/browse/OCPBUGS-9355