Bug 2103206

Summary: Summary for defaultCPUModel should mention CPU as capitalized word
Product: Container Native Virtualization (CNV) Reporter: SATHEESARAN <sasundar>
Component: InstallationAssignee: Simone Tiraboschi <stirabos>
Status: CLOSED ERRATA QA Contact: SATHEESARAN <sasundar>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.10.2CC: cnv-qe-bugs, ocohen, stirabos
Target Milestone: ---   
Target Release: 4.10.3   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: hco-bundle-registry-container-v4.10.3-9, hyperconverged-cluster-operator-container-v4.10.3-2 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-07-20 16:01:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2096287    

Description SATHEESARAN 2022-07-01 16:31:04 UTC 
Description of problem:
-----------------------
The bug 2096287 implemented the support for defaultCPUModel across the cluster.
The summary that explains this new feature initially explains that default CPU model, but later calls CPU as 'cpu'. It should be consistently called as CPU as this is a abbreviation and stands for 'Central Processing Unit' (CPU)

Example from PR - https://github.com/kubevirt/hyperconverged-cluster-operator/pull/2006/files
              defaulCPUModel:
                description: 'DefaultCPUModel defines a cluster default for CPU model:
                  default CPU model is set when vmi doesn''t have any cpu model. When
                  vmi has cpu model set, then vmi''s cpu model is preferred. When
                  default cpu model is not set and vmi''s cpu model is not set too,
                  host-model will be set. Default cpu model can be changed when kubevirt
                  is running.'
                type: string

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
CNV-4.10.3 (internal build, not yet GA'ed)

How reproducible:
-----------------
Always

Actual results:
---------------
CPU is used without capitalization as 'cpu'

Expected results:
-----------------
CPU should be mentioned as CPU ( capitalization )
Comment 1 Oren Cohen 2022-07-03 08:02:08 UTC 
Fixed, also capitalizing VMI in the description of the defaultCPUModel knob.
Comment 2 SATHEESARAN 2022-07-06 07:51:27 UTC 
Verified with hco-bundle v4.10.3-12, and hyperconverged-cluster-operator-v4.10.3-2

Summary is updated now and uses CPU and VMI, both of these words capitalized as follows:

<snip>
   defaultCPUModel	<string>
     DefaultCPUModel defines a cluster default for CPU model: default CPU model
     is set when VMI doesn't have any CPU model. When VMI has CPU model set,
     then VMI's CPU model is preferred. When default CPU model is not set and
     VMI's CPU model is not set too, host-model will be set. Default CPU model
     can be changed when kubevirt is running.
</snip>

As the summary is updated as expected, verifying this bug
Comment 8 errata-xmlrpc 2022-07-20 16:01:37 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Virtualization 4.10.3 Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2022:5675