Bug 2103664

Summary:	object names are not correct when installing ODF in external mode
Product:	[Red Hat Storage] Red Hat OpenShift Data Foundation	Reporter:	Tal Yichye <tal.yichye>
Component:	ocs-operator	Assignee:	Jose A. Rivera <jrivera>
Status:	CLOSED NOTABUG	QA Contact:	Martin Bukatovic <mbukatov>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.10	CC:	badhikar, bvered, jrivera, madam, muagarwa, nigoyal, ocs-bugs, odf-bz-bot, skatiyar, sostapov
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-07-19 13:22:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tal Yichye 2022-07-04 12:14:53 UTC

Description of problem (please be detailed as possible and provide log
snippests):

While installing RedHat ODF 4.10 with the StorageSystem IBM Flashsystem, the storage classes and storage cluster objects are created with incorrect names (without 'external' in their names).

Version of all relevant components (if applicable):
ODF 4.10.4
OCP 4.10

Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)? 
yes 

Is there any workaround available to the best of your knowledge?
no

Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?
1

Can this issue reproducible?
yes

Can this issue reproduce from the UI?
yes

If this is a regression, please provide more details to justify this:


Steps to Reproduce:
1. Install ODF 4.10 from UI
2. Creating IBM Flashsystem StorageSystem from UI
3. Check storage class names
4. Check storage cluster name


Actual results:
The objects are created without 'external' in their names.
List of created OCS storage cluster:
ocs-storagecluster

List of created OCS storage classes:
ocs-storagecluster-ceph-rbd
ocs-storagecluster-ceph-rgw
ocs-storagecluster-cephfs
openshift-storage.noobaa.io



Expected results:
The objects are created with 'external' in their names.

Additional info:

Comment 2 Nitin Goyal 2022-07-05 03:55:37 UTC

Hello Tal Yichye,

Is your storage class working as expected? Is it able to provision the storage? If yes why does the name concern you?

Comment 3 Tal Yichye 2022-07-05 06:02:40 UTC

Because the OCS-CI tests require the name to be different when running in external mode.

Comment 4 Nitin Goyal 2022-07-05 06:07:48 UTC

In that case it is a ocs-ci BUg and not a product bug.

Comment 5 Tal Yichye 2022-07-05 06:13:07 UTC

So when installing ODF in external mode, there are no expected names for these objects (storageclass, storagecluster) ?
I am asking because Bipul Adh told me something else, so I want to be sure.
Thanks.

Comment 6 Nitin Goyal 2022-07-05 06:20:07 UTC

@badhikar Can you pls clarify this?

Comment 7 Vered Berenstein Paz 2022-07-06 07:38:20 UTC

Hi Nitin Goyal and badhikar , 
Any update on this ticket?

Comment 8 Sanjal Katiyar 2022-07-13 09:02:47 UTC

Updates so far:
For IBM FlashSystem StorageSystem deployment, UI is creating the StorageCluster CR of internal type (seems intentional to me) and due to which OCS operator is creating the StorageClasses without external in it's name.

Since we have cephCluster CR as well in the system, there are couple of issues on the UI:
1) ODF's Block and File dashboard will be of internal type instead of external one (we have diff dashboards for both mode) as StorageCluster CR is of internal type even though it was external mode StorageSystem deployment.
2) BlockPools creation tab will be visible as well even though afaik we users are not allowed to create custom blockpool in external mode deployments.

So, current behaviour summarised is:
We were able to create PVC using the created StorageClasses and they were getting Bound with PV as well... only issue I can see is the one I mentioned above from the UI side regarding ODF's "Block and File" dashboards.

Comment 9 Sanjal Katiyar 2022-07-14 07:32:53 UTC

> Since we have cephCluster CR as well in the system, there are couple of
> issues on the UI:
> 1) ODF's Block and File dashboard will be of internal type instead of
> external one (we have diff dashboards for both mode) as StorageCluster CR is
> of internal type even though it was external mode StorageSystem deployment.
> 2) BlockPools creation tab will be visible as well even though afaik we
> users are not allowed to create custom blockpool in external mode
> deployments.

So, this is also not an issue from UI, we are creating ceph cluster internally (StorageCluster of internal type)... so dashboards we are showing are correct.

This seems to be a CI issue only and as mentioned https://bugzilla.redhat.com/show_bug.cgi?id=2103664#c4 should be solved from CI.

Comment 10 Mudit Agarwal 2022-07-19 13:22:59 UTC

Please check with the odf qe team who takes care of ci.