Bug 2104404

Summary: RFE: support to get thread-pool-max/thread-pool-min by query-iothreads
Product: Red Hat Enterprise Linux 9 Reporter: Han Han <hhan>
Component: qemu-kvmAssignee: Virtualization Maintenance <virt-maint>
qemu-kvm sub component: Storage QA Contact: qing.wang <qinwang>
Status: CLOSED WONTFIX Docs Contact:
Severity: medium    
Priority: medium CC: armbru, coli, junzhao, kkiwi, kwolf, virt-maint
Version: 9.1Keywords: FutureFeature, Triaged
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-07-12 09:44:18 UTC Type: Feature Request
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2104407    

Description Han Han 2022-07-06 07:40:38 UTC
Description of problem:
As subject

Version-Release number of selected component (if applicable):
qemu-kvm-7.0.0-8.el9.x86_64

How reproducible:
100%

Steps to Reproduce:
Setting the properties thread-pool-max/thread-pool-min of iothread objects are supported since BZ2031024.  
However, getting thread-pool-max/thread-pool-min by query-iothreads is not supported yet.  
No thread-pool-max/thread-pool-min properties in the result object IOThreadInfo for query-iothreads QMP, see https://gitlab.com/qemu-project/qemu/-/blob/master/qapi/misc.json#L72

Actual results:
As above

Expected results:
Support to get thread-pool-max/thread-pool-min by query-iothreads

Additional info:

Comment 3 CongLi 2022-07-12 09:44:18 UTC
The libvirt bug 2104407 has been closed, close the QEMU one too.

Comment 4 Kevin Wolf 2022-07-26 11:09:24 UTC
For the record, in case anyone stumbles across this bug report who needs the same functionality: This value can already be queried with the qom-get QMP command. Adding the information to query-iothreads would be more convenient, but is not a hard requirement for retrieving the value.

$ build/qemu-system-x86_64 -object iothread,id=t0 -qmp stdio
{"QMP": {"version": {"qemu": {"micro": 50, "minor": 0, "major": 7}, "package": "v7.0.0-2105-g2e177f879b"}, "capabilities": ["oob"]}}
{"execute":"qmp_capabilities"}
{"return": {}}
{"execute":"qom-get","arguments":{"path":"/objects/t0","property":"thread-pool-max"}}
{"return": 64}