Bug 2104642
| Summary: | Add a validation webhook for Nutanix machine provider spec in Machine API Operator | |||
|---|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Sid Shukla <sishukla> | |
| Component: | Cloud Compute | Assignee: | OpenShift Cluster Infrastructure Bugs <cluster-infrastructure-bug-bot> | |
| Cloud Compute sub component: | Other Providers | QA Contact: | sunzhaohua <zhsun> | |
| Status: | CLOSED ERRATA | Docs Contact: | ||
| Severity: | urgent | |||
| Priority: | unspecified | CC: | aarapov, mimccune, miyadav | |
| Version: | 4.11 | |||
| Target Milestone: | --- | |||
| Target Release: | 4.12.0 | |||
| Hardware: | All | |||
| OS: | All | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | No Doc Update | ||
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 2105382 (view as bug list) | Environment: | ||
| Last Closed: | 2023-01-17 19:51:47 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 2105382 | |||
|
Description
Sid Shukla
2022-07-06 18:54:51 UTC
there is another PR that should go along with this bug, i'm resetting to POST so we can add it. Validated on the build having both PRs [miyadav@miyadav ~]$ oc get clusterversion NAME VERSION AVAILABLE PROGRESSING SINCE STATUS version 4.11.0-0.ci.test-2022-07-13-031440-ci-ln-dvxww5t-latest True False 49m Cluster version is 4.11.0-0.ci.test-2022-07-13-031440-ci-ln-dvxww5t-latest [miyadav@miyadav ~]$ Results : [miyadav@miyadav ~]$ oc create -f rhv/nuatanix/ms_invalid.yaml ( removed user-data-secret Name , validation web hook worked ) Error from server (providerSpec.userDataSecret.name: Required value: name must be provided): error when creating "rhv/nuatanix/ms_invalid.yaml": admission webhook "validation.machineset.machine.openshift.io" denied the request: providerSpec.userDataSecret.name: Required value: name must be provided [miyadav@miyadav ~]$ vi rhv/nuatanix/ms_invalid.yaml (removed the whole credential secret field , it added it , seems mutating webhook worked ) [miyadav@miyadav ~]$ oc create -f rhv/nuatanix/ms_invalid.yaml machineset.machine.openshift.io/miyadav-642-jvdfk-worker-in created [miyadav@miyadav ~]$ oc get machines NAME PHASE TYPE REGION ZONE AGE miyadav-642-jvdfk-master-0 Running 54m miyadav-642-jvdfk-master-1 Running 54m miyadav-642-jvdfk-master-2 Running 54m miyadav-642-jvdfk-worker-df2vh Running 51m miyadav-642-jvdfk-worker-in-bl287 Running 6m32s miyadav-642-jvdfk-worker-in-t7drl Running 6m32s miyadav-642-jvdfk-worker-szq6s Running 51m [miyadav@miyadav ~]$ oc edit machineset miyadav-642-jvdfk-worker-in ( credential secret name removed) error: machinesets.machine.openshift.io "miyadav-642-jvdfk-worker-in" could not be patched: admission webhook "validation.machineset.machine.openshift.io" denied the request: providerSpec.credentialsSecret.name: Required value: name must be provided You can run `oc replace -f /tmp/oc-edit-835905139.yaml` to try this update again. [miyadav@miyadav ~]$ oc get mutatingwebhookconfiguration NAME WEBHOOKS AGE machine-api 2 57m [miyadav@miyadav ~]$ oc get ValidatingWebhookConfiguration NAME WEBHOOKS AGE alertmanagerconfigs.openshift.io 1 56m autoscaling.openshift.io 2 65m machine-api 2 66m multus.openshift.io 1 67m performance-addon-operator 1 68m prometheusrules.openshift.io 1 56m snapshot.storage.k8s.io 1 66m Additional Info : Looks good to me, please suggest if any other scenarios needed. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: OpenShift Container Platform 4.12.0 bug fix and security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2022:7399 |