Bug 2104645
| Summary: | amanda bugfix for build/test issue and missing 1st char in error message | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Bieringer <pb> | ||||||
| Component: | amanda | Assignee: | Jason Tibbitts <j> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | low | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 36 | CC: | fedora, jridky, j, pcahyna, phracek, rvokal | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | amanda-3.5.3-1.fc38 amanda-3.5.3-1.fc36 amanda-3.5.3-1.fc37 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2023-04-02 00:15:51 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
Created attachment 1895004 [details]
stop early enough on broken encoded string
Thanks for these. I will have to take a closer look but we will almost certainly take at least the hexencode fix if not both. Have these patches been sent upstream? They are preparing a 3.6.0 release so if you have bug fixes, it would be a very good idea to pass them on to the developers. no, patches were not sent to upstream so far, please relay the patches to them, thank you! It is in general better if the person who develops the patches is the person who interacts with upstream, because I'm not going to be able to do a particularly good job answering any questions, but if you simply do not wish to interact when them then I will try to do so. found sources on github, will submit PRs at least the hexencode is already known..haven't seen that before https://bugzilla.redhat.com/show_bug.cgi?id=2045195 I have incorporated the hexencode patch. I don't see any real reason not to import the other patch but since it's so inconsequential I will give upstream a bit of time to comment on it and keep this ticket open in the meantime. FEDORA-2023-1293196f34 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-1293196f34 FEDORA-2023-3d0619d767 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-3d0619d767 FEDORA-2023-e295804b3d has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e295804b3d FEDORA-2023-e295804b3d has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-e295804b3d` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-e295804b3d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-3d0619d767 has been pushed to the Fedora 38 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-3d0619d767 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-1293196f34 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-1293196f34` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-1293196f34 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-3d0619d767 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-1293196f34 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-e295804b3d has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. |
Created attachment 1895003 [details] fix missing 1st char in error message Description of problem: 2 issues were found during troubleshooting #1 missing 1st char in error message in case bsdtcp auth is used #2 build/test issue found Version-Release number of selected component (if applicable): amanda-3.5.1-33.fc36.x86_64 How reproducible: always #1 Current: $ /usr/sbin/amandad 4etpeername returned: Socket operation on non-socket related strace: write(10, "Wed Jul 06 08:15:15.221669936 2022: pid 228864: thd-0x5620f3861a00: amandad: getpeername returned: Socket operation on non-socket\n", 130) = 130 writev(1, [{iov_base="\0\0\0004", iov_len=4}, {iov_base="\0\0\0\1", iov_len=4}, {iov_base="\4etpeername returned: Socket operation on non-socket", iov_len=52}], 34etpeername returned: Socket operation on non-socket) = 60 => "g" from "getpeername" got lost Fix: amanda-3.5.1-bsdtcp-security.patch #2: during creation of a local build a test case failed: FAIL: hexencode-test $ ./hexencode-test ; echo $? PASS test_encode (total: 0.000151) (process:327685): GLib-ERROR **: 08:30:12.430: adding 18446744073709551615 to string would overflow PASS test_roundtrip (total: 0.000188) PASS test_roundtrip_rand (total: 0.002072) 1 Problem is test "test_decode" with case "%" which results in new_len=-1 Fix: amanda-3.5.1-amutil.patch