Bug 2105042 (rust-json5)

Summary:	Review Request: rust-json5 - Rust JSON5 serializer and deserializer which speaks Serde
Product:	[Fedora] Fedora	Reporter:	Peter Robinson <pbrobinson>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-07-17 17:37:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1269538, 2075529, 2105044

Description Peter Robinson 2022-07-07 18:45:18 UTC

SPEC: https://pbrobinson.fedorapeople.org/rust-json5.spec
SRPM: https://pbrobinson.fedorapeople.org/rust-json5-0.4.1-1.fc36.src.rpm

Description:
Rust JSON5 serializer and deserializer which speaks Serde

koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=89205477

FAS: pbrobinson

Comment 1 Fabio Valentini 2022-07-16 20:09:01 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (ISC) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 2 Kevin Fenzi 2022-07-17 16:30:11 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-json5

Comment 3 Fabio Valentini 2022-07-17 17:41:00 UTC

Please also build this package on f36 and f35. Maintaining consistency across branches, where possible, makes keeping the Rust stack in working state much easier for me, and reduces the likelihood of unexpected breakage.

Comment 4 Peter Robinson 2022-07-18 08:12:39 UTC

I hadn't planned to (I don't have a need) but sure.