Bug 2105165

Summary:	[IPI-IBMCloud] explain installconfig.platform.ibmcloud.resourceGroupName need update
Product:	OpenShift Container Platform	Reporter:	MayXu <maxu>
Component:	Installer	Assignee:	Christopher J Schaefer <cschaefe>
Installer sub component:	openshift-installer	QA Contact:	MayXu <maxu>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	low
Priority:	low	CC:	cschaefe, mpytlak, rdossant
Version:	4.11
Target Milestone:	---
Target Release:	4.12.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-01-17 19:51:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description MayXu 2022-07-08 07:36:01 UTC

Thanks for opening a bug report!
Before hitting the button, please fill in as much of the template below as you can.
If you leave out information, it's harder to help you.
Be ready for follow-up questions, and please respond in a timely manner.
If we can't reproduce a bug we might close your issue.
If we're wrong, PLEASE feel free to reopen it and explain why.

Version:

$ openshift-install version
Version: ocp-release:4.11.0-rc.1-x86_64

Platform:
IPI-on-IBMCloud

What happened?
when using the existing dedicated host to create the cluster, we could specify the resourceGroupName in install-config.yaml, but in description “This resource group must be empty with no other resources when trying to use it for creating a cluster.” This is confusing.
And also this description: “Destroying the cluster using installer will delete this resource group”, if we provided the dedicated host in a certain resource group, then installer shouldn’t delete this resource group.

Steps to Reproduce:
$openshift-install explain installconfig.platform.ibmcloud.resourceGroupName

Actual results:
KIND: InstallConfig
VERSION: v1

RESOURCE: <string>
ResourceGroupName is the name of an already existing resource group where the cluster should be installed. This resource group should only be used for this specific cluster and the cluster components will assume ownership of all resources in the resource group. Destroying the cluster using installer will delete this resource group.
This resource group must be empty with no other resources when trying to use it for creating a cluster. If empty, a new resource group will be created for the cluster.

Expected results:
…Destroying the cluster using the installer will delete this resource created by the installer.
This resource group must be empty except the dedicated hosts which will be used when trying to use it for creating a cluster….

Additional info:
https://docs.openshift.com/container-platform/4.10/installing/installing_ibm_cloud_public/installing-ibm-cloud-network-customizations.html#installation-configuration-parameters-additional-ibm-cloud_installing-ibm-cloud-network-customizations
https://cloud.ibm.com/docs/vpc?topic=vpc-creating-dedicated-hosts-instances

Comment 1 Christopher J Schaefer 2022-08-16 17:25:52 UTC

A fix was merged into 4.12 to update the resourceGroupName description.
https://github.com/openshift/installer/commit/60aeec4b8ceefd4a63f30c150b58ff9b86346a32#diff-ee27061f49f3641fa1c082879a6f0005c8986ece0519c3e286d91ae5a32947d8


# bin/openshift-install version
bin/openshift-install unreleased-master-6309-g26611ffdc1e130f0866eb5871fea887443b1e4bb
built from commit 26611ffdc1e130f0866eb5871fea887443b1e4bb
release image registry.ci.openshift.org/origin/release:4.12
release architecture amd64


# bin/openshift-install explain installconfig.platform.ibmcloud.resourceGroupName
KIND:     InstallConfig
VERSION:  v1

RESOURCE: <string>
  ResourceGroupName is the name of an already existing resource group where the cluster should be installed. If empty, a new resource group will be created for the cluster.



I am not sure if we plan to cherry-pick this fix back to 4.11 at this time, since IBM Cloud was a Tech Preview on that release.

Comment 2 Christopher J Schaefer 2022-08-16 17:27:27 UTC

PR that included the change mentioned above.
https://github.com/openshift/installer/pull/6050

Comment 4 MayXu 2022-08-17 04:09:26 UTC

checked with 4.12.0-0.nightly-2022-08-15-150248
$ ./openshift-install explain installconfig.platform.ibmcloud.resourceGroupName
KIND:     InstallConfig
VERSION:  v1

RESOURCE: <string>
  ResourceGroupName is the name of an already existing resource group where the cluster should be installed. If empty, a new resource group will be created for the cluster.

Comment 8 errata-xmlrpc 2023-01-17 19:51:48 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.12.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:7399