Bug 2105886

Summary: Review Request: rust-concolor-control - Control console coloring across all dependencies
Product: [Fedora] Fedora Reporter: Davide Cavalca <davide>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-08-13 15:57:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2105882    
Bug Blocks:    

Description Davide Cavalca 2022-07-11 05:11:43 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-concolor-control/rust-concolor-control.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-concolor-control/rust-concolor-control-0.0.7-1.fc37.src.rpm

Description:
Control console coloring across all dependencies.

Fedora Account System Username: dcavalca

Comment 1 Fabio Valentini 2022-08-11 16:54:12 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

Thanks for the upstream PR to include license files!
Looks like the next version won't need to contain so much manual work :)

BTW, missing license text from redistributed sources is also a problem with the Apache-2.0 license, not only MIT.

Comment 2 Davide Cavalca 2022-08-11 18:57:04 UTC
Thanks!

$ fedpkg request-repo rust-concolor-control 2105886
https://pagure.io/releng/fedora-scm-requests/issue/46382
$ fedpkg request-branch --repo rust-concolor-control f37
https://pagure.io/releng/fedora-scm-requests/issue/46383
$ fedpkg request-branch --repo rust-concolor-control f36
https://pagure.io/releng/fedora-scm-requests/issue/46384
$ fedpkg request-branch --repo rust-concolor-control f35
https://pagure.io/releng/fedora-scm-requests/issue/46385

Comment 3 Gwyn Ciesla 2022-08-11 19:04:01 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-concolor-control

Comment 4 Fedora Update System 2022-08-13 15:55:09 UTC
FEDORA-2022-f53d4ca024 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-f53d4ca024

Comment 5 Fedora Update System 2022-08-13 15:57:09 UTC
FEDORA-2022-f53d4ca024 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2022-08-13 16:03:46 UTC
FEDORA-2022-3a74eea734 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3a74eea734

Comment 7 Fedora Update System 2022-08-13 16:06:09 UTC
FEDORA-2022-3a74eea734 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2022-08-13 16:13:27 UTC
FEDORA-2022-10738db7ef has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-10738db7ef

Comment 9 Fedora Update System 2022-08-13 16:29:21 UTC
FEDORA-2022-638a408a84 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-638a408a84

Comment 10 Fedora Update System 2022-08-14 03:21:50 UTC
FEDORA-2022-10738db7ef has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-10738db7ef \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-10738db7ef

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2022-08-14 03:50:08 UTC
FEDORA-2022-638a408a84 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-638a408a84 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-638a408a84

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2022-08-22 01:10:46 UTC
FEDORA-2022-10738db7ef has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2022-08-22 01:34:29 UTC
FEDORA-2022-638a408a84 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.