Bug 2107277

Summary:	[RHEL8] Validation failed because does not support version 1.5
Product:	Red Hat Enterprise Linux 8	Reporter:	Troy Dawson <tdawson>
Component:	desktop-file-utils	Assignee:	David King <dking>
Status:	CLOSED ERRATA	QA Contact:	Tomas Pelka <tpelka>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	CentOS Stream	CC:	bstinson, dking, jwboyer, redhat-bugzilla, rstrode, tpelka, tpopela
Target Milestone:	rc	Keywords:	Rebase, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	desktop-file-utils-0.26-1.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-05-16 08:28:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Troy Dawson 2022-07-14 16:26:21 UTC

Description of problem:
I am receiving errors like the following on package builds that have newer .desktop files.

+ desktop-file-validate /builddir/build/BUILDROOT/kdebugsettings-22.04.1-1.el9.x86_64/usr/share/applications/org.kde.kdebugsettings.desktop
/builddir/build/BUILDROOT/kdebugsettings-22.04.1-1.el9.x86_64/usr/share/applications/org.kde.kdebugsettings.desktop: error: file contains key "SingleMainWindow" in group "Desktop Entry", but keys extending the format should start with "X-"

Version-Release number of selected component (if applicable):
desktop-file-utils-0.23-8.el8

Additional info:
https://gitlab.freedesktop.org/xdg/desktop-file-utils/-/issues/59
https://bugzilla.redhat.com/show_bug.cgi?id=2053905

It is affecting my updating of many KDE apps in epel.

Comment 1 Tomas Popela 2022-07-15 06:20:26 UTC

I see that David made the required changes in Fedora with https://src.fedoraproject.org/rpms/desktop-file-utils/pull-request/1

Comment 2 Ray Strode [halfline] 2022-10-21 15:19:09 UTC

patch already available devack+

Comment 4 David King 2022-11-09 08:24:38 UTC

I tried to quickly backport the upstream patch, but there are quite a few changes between the 0.23 in RHEL 8 and the 0.26 that the patch is against, including spec 1.4 and 1.2 support, and several important changes and additions to supported desktop file keys. I would suppose that a rebase to 0.26 and the (small) patch to support spec 1.5 will be much less risky (and less devel time) than cherry-picking a large number of patches required to support all the intermediate spec versions.

Comment 5 Tomas Popela 2022-11-09 08:30:01 UTC

I thing that we can go with the rebase, but we have to keep in mind that desktop-file-utils is shipped in AppStream and it does have a default ACG level set - that means no API/ABI changes are allowed.

Comment 6 David King 2022-11-09 08:36:40 UTC

(In reply to Tomas Popela from comment #5)
> I thing that we can go with the rebase, but we have to keep in mind that
> desktop-file-utils is shipped in AppStream and it does have a default ACG
> level set - that means no API/ABI changes are allowed.

I think that in this case that should be fine, as the commits are all additions to supported spec versions and keys, build system changes (port to Meson), small feature additions and bugfixes. As desktop-file-utils does not provide a library API, and the CLI has not had any removals, I would say that the risk of regressions is very low.

Comment 7 Tomas Popela 2022-11-09 10:24:04 UTC

Ah, at that point it makes sense. Please adjust the DTM.

Comment 13 errata-xmlrpc 2023-05-16 08:28:42 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (desktop-file-utils bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2793