Bug 2107440

Description of problem: About a month ago, virt-install stopped being able to install from Fedora Rawhide boot.iso (i.e. what Anaconda does). Our last refresh [1] happened on June 13, which was still okay. It started to fail on June 21 [2], unfortunately due to PTOs and lack of time we did not report this straight away.

The structure of boot.iso changed, they stopped having an /isolinux directory, which virt-install depends on. So this may have been deliberate, and virt-install needs to be adjusted; or it's a bug in the Rawhide image build process, then this needs to be reassigned.


Version-Release number of selected component (if applicable):

virt-install-3.2.0-5.fc35.noarch


How reproducible: Always


Steps to Reproduce:
1. Download https://download.fedoraproject.org/pub/fedora/linux/development/rawhide/Server/x86_64/os/images/boot.iso

2. Install necessary dependencies:
   sudo dnf install -y virt-install qemu-device-usb-redirect qemu-char-spice

3. Try to boot it:
   virt-install --debug --name r --os-variant fedora-rawhide --memory 2048 --autoconsole text --extra-args 'inst.sshd' --network none --wait -1 --location `pwd`/boot.iso


Actual results: Fails with

Starting install...
[Fri, 15 Jul 2022 06:57:11 virt-install 270771] DEBUG (urlfetcher:141) hasFile(/isolinux/vmlinuz) returning False
[Fri, 15 Jul 2022 06:57:11 virt-install 270771] ERROR (cli:256) Couldn't find kernel for install tree.


Expected results: The last image booted, and said this:

Starting install...
[Fri, 15 Jul 2022 06:55:07 virt-install 270634] DEBUG (urlfetcher:141) hasFile(/isolinux/vmlinuz) returning True
[Fri, 15 Jul 2022 06:55:07 virt-install 270634] DEBUG (urlfetcher:141) hasFile(/isolinux/initrd.img) returning True
[Fri, 15 Jul 2022 06:55:07 virt-install 270634] DEBUG (urlfetcher:320) Running isoinfo: ['isoinfo', '-J', '-i', '/var/home/martin/.cache/cockpit-images/fedora-rawhide-boot-33a9f28780f40d85b37ece165a9297808a20152af55c5c89b544c0f5872f7608.iso', '-x', '/isolinux/vmlinuz']
[Fri, 15 Jul 2022 06:55:07 virt-install 270634] DEBUG (urlfetcher:72) Fetching URI: /isolinux/vmlinuz
Retrieving file vmlinuz...                                                                                       |  12 MB  00:00:00     
[Fri, 15 Jul 2022 06:55:07 virt-install 270634] DEBUG (urlfetcher:158) Saved file to /var/home/martin/.cache/virt-manager/boot/virtinst-ot9hdqm_-vmlinuz


Additional info:

`isoinfo -J -i boot.iso` on the *old* image (the one that was still working) shows:

Directory listing of /isolinux/

----------   0    0    0       105009392 Jun 12 2022 [ 324912 00]  initrd.img 
----------   0    0    0           38912 Jan 27 2022 [  15817 00]  isolinux.bin 
----------   0    0    0            2834 Jun 12 2022 [ 382521 00]  isolinux.cfg 
----------   0    0    0        12967088 Jun 10 2022 [ 376187 00]  vmlinuz 
[...]

The current image does not have /isolinux at all. It *does* have a kernel and initrd, though:

Directory listing of /images/pxeboot/
d---------   0    0    0            2048 Jul 12 2022 [    113 02]  . 
d---------   0    0    0            2048 Jul 12 2022 [    113 02]  .. 
----------   0    0    0       100766272 Jul 12 2022 [ 280065 00]  initrd.img 
----------   0    0    0        11975760 Jul 11 2022 [ 329268 00]  vmlinuz 

Older images have that as well. The sizes are the same, so that may be the one that virt-install should look at?


[1] https://github.com/cockpit-project/bots/pull/3502
[2] https://github.com/cockpit-project/bots/pull/3529