Bug 2107888
| Summary: | Review Request: vale - A syntax-aware, command-line linter for prose | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marek Czernek <mczernek> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | me, mikel, package-review, ppisar |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-10-24 08:12:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Marek Czernek
2022-07-17 08:02:10 UTC
Hi Marek, Fedora builds don't have access to Internet, so all the required libraries need to be part of Fedora. For golang packages this means that the package is unbundled: "At the moment golang projects packaged in Fedora SHOULD be unbundled by default. It means projects are built from dependencies packaged in Fedora." https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_bundled_or_unbundled I'll recommend you to use `go2rpm` to create a package and then work on top of that. $ go2rpm -r github.com/errata-ai/vale or in case you want to have static BuildRequires: $ go2rpm -r --no-dynamic-buildrequires github.com/errata-ai/vale Trying to build the spec generated by go2rpm, the build process reports the following dependencies missing: No matching package to install: 'golang(github.com/errata-ai/ini)' No matching package to install: 'golang(github.com/errata-ai/regexp2)' No matching package to install: 'golang(github.com/jdkato/regexp)' No matching package to install: 'golang(github.com/jdkato/titlecase)' No matching package to install: 'golang(github.com/pterm/pterm)' Those should be imported first to Fedora and then go with vale. The spec generated by go2rpm will need some tweaking, but it's a good start to detect missing dependencies. Thank you, for the detailed review, I didn't realize that the COPR and the official Fedora build process are different (makes sense in retrospect). I'll see what I can do with the missing dependencies. M. This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted. This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted. This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket. An account of the review submitter was close. |