Bug 2108003

Summary: 4.10: do not block 4.10 to 4.11 upgrades if an existing CSI driver is found. Instead, warn about presence of third party CSI driver
Product: OpenShift Container Platform Reporter: Jan Safranek <jsafrane>
Component: StorageAssignee: Jan Safranek <jsafrane>
Storage sub component: Operators QA Contact: Wei Duan <wduan>
Status: CLOSED ERRATA Docs Contact:
Severity: high    
Priority: medium CC: gcharot, hekumar, jsafrane, pewang, wduan
Version: 4.10   
Target Milestone: ---   
Target Release: 4.10.z   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 2089419 Environment:
Last Closed: 2022-07-25 07:07:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2089419    
Bug Blocks:    

Comment 1 Jan Safranek 2022-07-18 11:41:02 UTC
The ClusterCSIDriver Upgradeable condition should be "True" with an extra message:

    - lastTransitionTime: "2022-07-18T11:19:39Z"
      message: found existing unsupported csi.vsphere.vmware.com driver
      reason: existing_driver_found
      status: "True"
      type: VMwareVSphereControllerUpgradeable

I'll open a separate BZ to get an alert for it, as it needs some changes in 4.12+4.11 too.

Comment 4 Wei Duan 2022-07-21 01:17:00 UTC
Verified pass on 4.10.0-0.nightly-2022-07-19-210744:
1. Upgradeable is True:
$ oc get co storage -o yaml
    message: 'VSphereCSIDriverOperatorCRUpgradeable: VMwareVSphereControllerUpgradeable:
      found existing unsupported csi.vsphere.vmware.com driver'
    reason: AsExpected
    status: "True"
    type: Upgradeable

2. no VSphereCSIDriverOperatorCR_VMwareVSphereController_check_deprecated_esxi_version when performing "oc adm upgrade"  
$ oc adm upgrade
Cluster version is 4.10.0-0.nightly-2022-07-19-210744

Upstream is unset, so the cluster will use an appropriate default.
Channel: stable-4.9
warning: Cannot display available updates:
  Reason: VersionNotFound
  Message: Unable to retrieve available updates: currently reconciling cluster version 4.10.0-0.nightly-2022-07-19-210744 not found in the "stable-4.9" channel

3. (Not the scope of this BZ fix, just record the test result) The storageclass "thin-csi" is still created when we did not install vSphere CSI Driver, it was tracked by another separate BZ. 

Move to "VERIFIED"

Comment 6 errata-xmlrpc 2022-07-25 07:07:09 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.10.24 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5664