Bug 2108223

Summary:	Add warning for empty targetattr when creating ACI with RBAC
Product:	Red Hat Enterprise Linux 9	Reporter:	Rob Crittenden <rcritten>
Component:	ipa	Assignee:	Rob Crittenden <rcritten>
Status:	CLOSED DUPLICATE	QA Contact:	ipa-qe <ipa-qe>
Severity:	low	Docs Contact:
Priority:	low
Version:	9.1	CC:	asharov, frenaud, ftrivino, ipa-qe, myusuf, rcritten, tscherf
Target Milestone:	rc	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	2098187	Environment:
Last Closed:	2022-11-25 09:57:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2098187, 2148379
Bug Blocks:

Description Rob Crittenden 2022-07-18 15:57:02 UTC

+++ This bug was initially created as a clone of Bug #2098187 +++

Description of problem:
When we create RBAC permission, with CLI or WebUI, we can create permission with empty target attribute list. 

This will act as we didn't permit any attributes to be accessed, so permission without attributes won't do anything.


Version-Release number of selected component (if applicable):
RHEL 8.6
ipa-server-4.9.8-7
389-ds-base-1.4.3.28-6

How reproducible:
always

Expected results:
we should probably add a warning that empty target attributes are not really meaningful. Or just make this mandatory.

Additional info:

--- Additional comment from Florence Blanc-Renaud on 2022-06-17 15:33:41 UTC ---

Discussed on idm-tech: https://groups.google.com/a/redhat.com/g/idm-tech/c/LuMeD9AczEU

--- Additional comment from Rob Crittenden on 2022-06-22 15:13:16 UTC ---

Linked to upstream issue https://pagure.io/freeipa/issue/9188

--- Additional comment from Florence Blanc-Renaud on 2022-07-15 15:01:34 UTC ---

Fixed upstream
master:
https://pagure.io/freeipa/c/dc73813b8afccb82b513c49b29de35b7864819b6

--- Additional comment from Florence Blanc-Renaud on 2022-07-15 15:06:38 UTC ---

Note to QA: the xmlrpc tests already check that the warning is displayed:

ipatests/test_xmlrpc/test_old_permission_plugin.py::test_old_permission
ipatests/test_xmlrpc/test_permission_plugin.py::test_permission_bindtype and ::test_permission_filters
ipatests/test_xmlrpc/test_privilege_plugin.py::test_privilege

--- Additional comment from Florence Blanc-Renaud on 2022-07-16 05:58:41 UTC ---

Fixed upstream
ipa-4-10:
https://pagure.io/freeipa/c/499f71729b8689d40608d9c99db703eb2c00a934

ipa-4-9:
https://pagure.io/freeipa/c/b31631ad69f72fb42b5091375df8021580f8139a

Comment 1 Florence Blanc-Renaud 2022-11-25 09:57:38 UTC


*** This bug has been marked as a duplicate of bug 2148379 ***