Bug 2108499

Summary: [RFE] [cephadm] : orch upgrade status : status to depict that upgrade is currently paused in case of error
Product: [Red Hat Storage] Red Hat Ceph Storage Reporter: Vasishta <vashastr>
Component: CephadmAssignee: Adam King <adking>
Status: NEW --- QA Contact: Manasa <mgowri>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 5.2CC: cephqe-warriors, saraut
Target Milestone: ---Keywords: FutureFeature
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Vasishta 2022-07-19 08:16:33 UTC
Description of problem:
Tried upgrade from one build to another build.

Image pull failed due to some DNS issue in image registry host.

After DNS issue got fixed, upgrade did not proceed.

Thought of restarting upgrade process as the upgrade in_progress was true.

Tried upgrade pause to resume back considering it as resume.

It would have been nice if upgrade status mentioned that upgrade is currently paced due to Error.

Version-Release number of selected component (if applicable):
16.2.8-75.el8cp

How reproducible:
Tried twice faced twice.

Steps to Reproduce:
1. Try upgrade of cluster using ceph orchestrator and induce failure as mentioned above.
2. Check upgrade status.

Actual results:
[ubuntu@magna032 ~]$ sudo ceph orch upgrade status
{
    "target_image": "registry-proxy.engineering.redhat.com/rh-osbs/rhceph:ceph-5.2-rhel-8-containers-candidate-66591-20220715201234",
    "in_progress": true,
    "which": "Upgrading all daemon types on all hosts",
    "services_complete": [],
    "progress": "",
    "message": "Error: UPGRADE_FAILED_PULL: Upgrade: failed to pull target image"
}
[ubuntu@magna032 ~]$ sudo ceph orch upgrade pause
Upgrade to registry-proxy.engineering.redhat.com/rh-osbs/rhceph:ceph-5.2-rhel-8-containers-candidate-66591-20220715201234 already paused

Expected results:
ceph orch upgrade to depect that the upgrade is paused.

Additional info:
This is an enhancement request from usability enhancement perspective.