Bug 2108619

Summary: ClusterVersion history pruner does not always retain initial completed update entry
Product: OpenShift Container Platform Reporter: OpenShift BugZilla Robot <openshift-bugzilla-robot>
Component: Cluster Version OperatorAssignee: Jack Ottofaro <jack.ottofaro>
Status: CLOSED ERRATA QA Contact: Evgeni Vakhonin <evakhoni>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.11CC: aos-team-ota, wking
Target Milestone: ---Keywords: FastFix
Target Release: 4.9.z   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-08-09 14:01:08 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2108292    
Bug Blocks: 2109962    

Comment 1 Evgeni Vakhonin 2022-07-20 04:54:08 UTC 
using the same method as in https://bugzilla.redhat.com/show_bug.cgi?id=2108292#c1

reproducing on 4.9.40 to 4.9.43


passed: history lenght is 50
last 3 items before prune
[
  {
    "completionTime": "2022-07-19T20:55:04Z",
    "image": "quay.io/openshift-release-dev/ocp-release@sha256:ed3b2eac54ea3406e516b08cbb4f0c488bf47f9200664239bdc266bc29ac7cca",
    "startedTime": "2022-07-19T20:54:21Z",
    "state": "Completed",
    "verified": true,
    "version": "4.9.40"
  },
  {
    "completionTime": "2022-07-19T20:54:21Z",
    "image": "quay.io/openshift-release-dev/ocp-release@sha256:93256bbe6227fea0f8c89c6c194888ce1e2277feecb75002e401a42a2465730b",
    "startedTime": "2022-07-19T20:53:56Z",
    "state": "Partial",
    "verified": true,
    "version": "4.9.43"
  },
  {
    "completionTime": "2022-07-19T20:41:42Z",
    "image": "quay.io/openshift-release-dev/ocp-release@sha256:ed3b2eac54ea3406e516b08cbb4f0c488bf47f9200664239bdc266bc29ac7cca",
    "startedTime": "2022-07-19T20:21:09Z",
    "state": "Completed",
    "verified": false,
    "version": "4.9.40"
  }
]

sending upgrade command: to 4.9.40
passed: waiting for upgrade to start: 4.9.40
passed: history lenght still 50
last 3 items after prune
[
  {
    "completionTime": "2022-07-19T20:55:36Z",
    "image": "quay.io/openshift-release-dev/ocp-release@sha256:93256bbe6227fea0f8c89c6c194888ce1e2277feecb75002e401a42a2465730b",
    "startedTime": "2022-07-19T20:55:25Z",
    "state": "Partial",
    "verified": true,
    "version": "4.9.43"
  },
  {
    "completionTime": "2022-07-19T20:55:04Z",
    "image": "quay.io/openshift-release-dev/ocp-release@sha256:ed3b2eac54ea3406e516b08cbb4f0c488bf47f9200664239bdc266bc29ac7cca",
    "startedTime": "2022-07-19T20:54:21Z",
    "state": "Completed",
    "verified": true,
    "version": "4.9.40"
  },
  {
    "completionTime": "2022-07-19T20:54:21Z",
    "image": "quay.io/openshift-release-dev/ocp-release@sha256:93256bbe6227fea0f8c89c6c194888ce1e2277feecb75002e401a42a2465730b",
    "startedTime": "2022-07-19T20:53:56Z",
    "state": "Partial",
    "verified": true,
    "version": "4.9.43"
  }
]

reproduced successfully - the last "Completed" item was pruned.







pre-merge verifying on 4.9.0-0.ci.test-2022-07-19-173235-ci-ln-3y85f1b-latest to 4.9.0-0.ci.test-2022-07-19-173244-ci-ln-1gwqzmt-latest. same method.

passed: history lenght is 50
last 3 items before prune
[
  {
    "completionTime": "2022-07-19T18:53:48Z",
    "image": "registry.build05.ci.openshift.org/ci-ln-3y85f1b/release@sha256:4b95c323eacdc18c053c55a10feefd85d8b39ab80eed6a646506a2fed193dba3",
    "startedTime": "2022-07-19T18:52:51Z",
    "state": "Completed",
    "verified": false,
    "version": "4.9.0-0.ci.test-2022-07-19-173235-ci-ln-3y85f1b-latest"
  },
  {
    "completionTime": "2022-07-19T18:52:51Z",
    "image": "registry.build05.ci.openshift.org/ci-ln-1gwqzmt/release@sha256:d1166644df7fbac046daa88bbef9ad8abb70fdf24d7005e6360d43f83ea371ff",
    "startedTime": "2022-07-19T18:52:34Z",
    "state": "Partial",
    "verified": false,
    "version": "4.9.0-0.ci.test-2022-07-19-173244-ci-ln-1gwqzmt-latest"
  },
  {
    "completionTime": "2022-07-19T18:03:55Z",
    "image": "registry.build05.ci.openshift.org/ci-ln-3y85f1b/release@sha256:4b95c323eacdc18c053c55a10feefd85d8b39ab80eed6a646506a2fed193dba3",
    "startedTime": "2022-07-19T17:44:40Z",
    "state": "Completed",
    "verified": false,
    "version": "4.9.0-0.ci.test-2022-07-19-173235-ci-ln-3y85f1b-latest"
  }
]

sending upgrade command: to 4.9.0-0.ci.test-2022-07-19-173235-ci-ln-3y85f1b-latest
passed: waiting for upgrade to start: 4.9.0-0.ci.test-2022-07-19-173235-ci-ln-3y85f1b-latest
passed: history lenght still 50
last 3 items after prune
[
  {
    "completionTime": "2022-07-19T18:54:22Z",
    "image": "registry.build05.ci.openshift.org/ci-ln-1gwqzmt/release@sha256:d1166644df7fbac046daa88bbef9ad8abb70fdf24d7005e6360d43f83ea371ff",
    "startedTime": "2022-07-19T18:54:11Z",
    "state": "Partial",
    "verified": false,
    "version": "4.9.0-0.ci.test-2022-07-19-173244-ci-ln-1gwqzmt-latest"
  },
  {
    "completionTime": "2022-07-19T18:53:48Z",
    "image": "registry.build05.ci.openshift.org/ci-ln-3y85f1b/release@sha256:4b95c323eacdc18c053c55a10feefd85d8b39ab80eed6a646506a2fed193dba3",
    "startedTime": "2022-07-19T18:52:51Z",
    "state": "Completed",
    "verified": false,
    "version": "4.9.0-0.ci.test-2022-07-19-173235-ci-ln-3y85f1b-latest"
  },
  {
    "completionTime": "2022-07-19T18:03:55Z",
    "image": "registry.build05.ci.openshift.org/ci-ln-3y85f1b/release@sha256:4b95c323eacdc18c053c55a10feefd85d8b39ab80eed6a646506a2fed193dba3",
    "startedTime": "2022-07-19T17:44:40Z",
    "state": "Completed",
    "verified": false,
    "version": "4.9.0-0.ci.test-2022-07-19-173235-ci-ln-3y85f1b-latest"
  }
]

Verified successfully - the last "Completed" item was preserved, while the next "Partial" was pruned as expected.
Comment 6 errata-xmlrpc 2022-08-09 14:01:08 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.9.45 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5879