Bug 2108905

Summary:	Review Request: webkitgtk - GTK web content engine library
Product:	[Fedora] Fedora	Reporter:	Michael Catanzaro <mcatanza>
Component:	Package Review	Assignee:	Kalev Lember <klember>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	klember, package-review, tpopela
Target Milestone:	---	Flags:	klember: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-08-04 21:40:28 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michael Catanzaro 2022-07-20 01:02:06 UTC

Spec URL: https://catanzaro.fedorapeople.org/webkitgtk-review/webkitgtk.spec
SRPM URL: https://catanzaro.fedorapeople.org/webkitgtk-review/webkitgtk-2.37.1-1.fc37.src.rpm
Description: WebKitGTK is the port of the WebKit web rendering engine to the
GTK platform.
Fedora Account System Username: catanzaro

The point of this new source package is to build WebKitGTK multiple times with different build options:

webkit2gtk5.0: GTK 4
webkit2gtk4.1: GTK 3, libsoup 3
webkit2gtk4.0: GTK 3, libsoup 2

This does not yet include webkit2gtk5.0 because it's not stable yet. (E.g. we might remove the '2' from the API version, which would affect the package naming.) So for now it just includes webkit2gtk4.1 and webkit2gtk4.0.

We added webkitgtk4.1 to the existing webkit2gtk3 package today as a temporary emergency measure to try to get GNOME packages into good shape before the mass rebuild. webkit2gtk3 will be retired once this new source package is approved.

The webkit2gtk4.0 packages are identical to and obsolete the existing webkit2gtk3 package, as well as the older webkitgtk4 package before that. Different names, same thing. I plan to remove these subpackages next year.

Because it takes a very long time to build this package, I went ahead and ran fedora-review myself and uploaded the content raw and unedited as a starting point: https://catanzaro.fedorapeople.org/webkitgtk-review/review.txt. Of course some of the complaints there are silly, e.g. it doesn't know about rpm-autospec.

I notice an error already, it provides libwebkit2gtkinjectedbundle.so()(64bit), but this is private and should have been filtered out. Will investigate that.

Lastly, I'm a bit confused why there is a webkitgtk-debuginfo package even though there is no webkitgtk binary package. But it's small and seems harmless.

Comment 1 Kalev Lember 2022-07-21 10:39:31 UTC

This seems broadly fine to me. Makes a lot of sense to build all of these from the same source package. I'd like to see a scratch build succeed before approving this though, just to make sure it has a chance of building in koji as the package is just so big.

On the same note, maybe you could add the GTK4 version to the spec file already now, just to see if it's possible to build all 3 versions from the same package without running into issues with koji builders running out of memory? It's fine to just '%if 0' it out afterwards if you don't want to actually ship it yet. It's really up to you how prudent you want to be; we can always split this up afterwards again if koji can't handle building it.

Another thing I noticed is that various 4.0 packages seem to be missing license files. Can you make sure they match with what's shipped in the 4.1 packages?

e.g.
%files -n webkit2gtk4.1-jsc
%license _license_files/*JavaScriptCore*
%{_libdir}/libjavascriptcoregtk-4.1.so.0*
%dir %{_libdir}/girepository-1.0
%{_libdir}/girepository-1.0/JavaScriptCore-4.1.typelib

%files -n webkit2gtk4.0-jsc
%{_libdir}/libjavascriptcoregtk-4.0.so.18*
%dir %{_libdir}/girepository-1.0
%{_libdir}/girepository-1.0/JavaScriptCore-4.0.typelib

... where the 4.0 version is missing %license.

Upgrade path seems sane to me (all the various subpackages that got renamed from webkit2gtk3 -> webkit2gtk4.0 all seem to have correct obsoletes and provides). The sources are identical (and in fact, the binary package content as well, minus the license files issue pointed out above) is identical to what's shipped in rawhide right now so I think this package should be fine to go in.

Comment 2 Kalev Lember 2022-07-21 10:50:30 UTC

Oh, two more things:

Can you add webkit2gtk3%{?_isa} provides to webkit2gtk4.0? There are packages that do 'Requires: webkit2gtk3%{?_isa}' so we need matching provides here.

Similarly, can you add all of the webkit2gtk4.0 provides to the existing webkit2gtk3 packages in F35 and F36? People like to use the same spec file that works across all of the branches and that makes things a bit easier for them - that way they can do 'BuildRequires: webkit2gtk4.0-devel' or 'Requires: webkit2gtk4.0%{?_isa}' across all Fedora branches and expect it to work.

Comment 3 Tomas Popela 2022-07-21 12:06:15 UTC

> %cmake_build %limit_build -m 2048

Don't you want to raise the value as you've done lately when Kalev hit the build issues?

Comment 4 Michael Catanzaro 2022-07-21 20:49:58 UTC

(In reply to Kalev Lember from comment #1)
> This seems broadly fine to me. Makes a lot of sense to build all of these
> from the same source package. I'd like to see a scratch build succeed before
> approving this though, just to make sure it has a chance of building in koji
> as the package is just so big.

Currently it should succeed on all architectures except s390x, which is broken, see:

https://pagure.io/releng/issue/10909
https://pagure.io/releng/issue/10910

> On the same note, maybe you could add the GTK4 version to the spec file
> already now, just to see if it's possible to build all 3 versions from the
> same package without running into issues with koji builders running out of
> memory? It's fine to just '%if 0' it out afterwards if you don't want to
> actually ship it yet. It's really up to you how prudent you want to be; we
> can always split this up afterwards again if koji can't handle building it.

This seems prudent. OK.

> Another thing I noticed is that various 4.0 packages seem to be missing
> license files. Can you make sure they match with what's shipped in the 4.1
> packages?
> 
> e.g.
> %files -n webkit2gtk4.1-jsc
> %license _license_files/*JavaScriptCore*
> %{_libdir}/libjavascriptcoregtk-4.1.so.0*
> %dir %{_libdir}/girepository-1.0
> %{_libdir}/girepository-1.0/JavaScriptCore-4.1.typelib
> 
> %files -n webkit2gtk4.0-jsc
> %{_libdir}/libjavascriptcoregtk-4.0.so.18*
> %dir %{_libdir}/girepository-1.0
> %{_libdir}/girepository-1.0/JavaScriptCore-4.0.typelib
> 
> ... where the 4.0 version is missing %license.

Ah, I guess it's possible for the same file to go into multiple subpackages, as long as it's identical? OK then.

> Can you add webkit2gtk3%{?_isa} provides to webkit2gtk4.0? There are packages that do 'Requires: webkit2gtk3%{?_isa}' so we need matching provides here.

Sure.

> Similarly, can you add all of the webkit2gtk4.0 provides to the existing webkit2gtk3 packages in F35 and F36? People like to use the same spec file that works across all of the branches and that makes things a bit easier for them - that way they can do 'BuildRequires: webkit2gtk4.0-devel' or 'Requires: webkit2gtk4.0%{?_isa}' across all Fedora branches and expect it to work.

Sure.

> Don't you want to raise the value as you've done lately when Kalev hit the build issues?

Nah, I think it just slows things down without increasing robustness. Kalev thinks the builders were dying when processing debuginfo, which is not parallelized.

Comment 5 Kalev Lember 2022-07-21 21:05:20 UTC

(In reply to Michael Catanzaro from comment #4)
> (In reply to Kalev Lember from comment #1)
> > Another thing I noticed is that various 4.0 packages seem to be missing
> > license files. Can you make sure they match with what's shipped in the 4.1
> > packages?
> > 
> > e.g.
> > %files -n webkit2gtk4.1-jsc
> > %license _license_files/*JavaScriptCore*
> > %{_libdir}/libjavascriptcoregtk-4.1.so.0*
> > %dir %{_libdir}/girepository-1.0
> > %{_libdir}/girepository-1.0/JavaScriptCore-4.1.typelib
> > 
> > %files -n webkit2gtk4.0-jsc
> > %{_libdir}/libjavascriptcoregtk-4.0.so.18*
> > %dir %{_libdir}/girepository-1.0
> > %{_libdir}/girepository-1.0/JavaScriptCore-4.0.typelib
> > 
> > ... where the 4.0 version is missing %license.
> 
> Ah, I guess it's possible for the same file to go into multiple subpackages,
> as long as it's identical? OK then.

Yes, it's possible to share identical files between subpackages, but that's not what's happening here. The %license macro (when called on a file in the source tree) copies the file to /usr/share/licenses/<binary_package_name>/

So if you have:

%files -n webkit2gtk4.0-jsc
%license _license_files/*JavaScriptCore*

%files -n webkit2gtk4.1-jsc
%license _license_files/*JavaScriptCore*

it copies _license_files/*JavaScriptCore* to both /usr/share/licenses/webkit2gtk4.0-jsc/ and /usr/share/licenses/webkit2gtk4.1-jsc/ which are different paths.

Comment 6 Michael Catanzaro 2022-07-22 14:45:55 UTC

I've also decided to rename e.g. webkit2gtk4.1-jsc -> javascriptcoregtk4.1.

Comment 7 Michael Catanzaro 2022-07-22 15:00:39 UTC

(In reply to Kalev Lember from comment #2)
> Oh, two more things:
> 
> Can you add webkit2gtk3%{?_isa} provides to webkit2gtk4.0? There are
> packages that do 'Requires: webkit2gtk3%{?_isa}' so we need matching
> provides here.

Does it have to be separate? E.g. we currently have:

Obsoletes:      webkitgtk4 < %{version}-%{release}
Provides:       webkitgtk4 = %{version}-%{release}
Obsoletes:      webkit2gtk3 < %{version}-%{release}
Provides:       webkit2gtk3 = %{version}-%{release}

Are you looking for this:

Obsoletes:      webkitgtk4 < %{version}-%{release}
Provides:       webkitgtk4 = %{version}-%{release}
Obsoletes:      webkitgtk4%{?_isa} < %{version}-%{release}
Provides:       webkitgtk4%{?_isa} = %{version}-%{release}
Obsoletes:      webkit2gtk3 < %{version}-%{release}
Provides:       webkit2gtk3 = %{version}-%{release}
Obsoletes:      webkit2gtk3%{?_isa} < %{version}-%{release}
Provides:       webkit2gtk3%{?_isa} = %{version}-%{release}

Or is it sufficient to do this:

Obsoletes:      webkitgtk4%{?_isa} < %{version}-%{release}
Provides:       webkitgtk4%{?_isa} = %{version}-%{release}
Obsoletes:      webkit2gtk3%{?_isa} < %{version}-%{release}
Provides:       webkit2gtk3%{?_isa} = %{version}-%{release}

Comment 8 Kalev Lember 2022-07-22 18:09:41 UTC

I was looking for this:

Obsoletes:      webkitgtk4 < %{version}-%{release}
Provides:       webkitgtk4 = %{version}-%{release}
Obsoletes:      webkit2gtk3 < %{version}-%{release}
Provides:       webkit2gtk3 = %{version}-%{release}
Provides:       webkit2gtk3%{?_isa} = %{version}-%{release}

As in, just to add 'Provides: webkit2gtk3%{?_isa} = %{version}-%{release}' and nothing else. However, looking closely, it seems that in practice we only had one package, gnome-online-accounts that expressed that kind of dependency and it's already switched over to webkit2gtk4.1: https://src.fedoraproject.org/rpms/gnome-online-accounts/c/cd351b3df00c88ea73cba0dd325763e32d9fa32d?branch=rawhide

So I take that back, no need to add the %{_isa} provides after all since there doesn't seem to be anything left in rawhide using it :)

> I've also decided to rename e.g. webkit2gtk4.1-jsc -> javascriptcoregtk4.1.

Makes sense to me.

Comment 9 Michael Catanzaro 2022-07-22 23:41:01 UTC

I've updated the spec, SRPM, and fedora-review output links in my first comment. Note that for testing purposes, it uses %bcond_without gtk4 with a FIXME above it, so that GTK 4 is enabled for review purposes. When I import the package for real, I will change that to %bcond_with to disable it until outstanding questions regarding the GTK 4 API have been resolved.

Comment 10 Michael Catanzaro 2022-07-23 12:30:14 UTC

(In reply to Kalev Lember from comment #1)
> On the same note, maybe you could add the GTK4 version to the spec file
> already now, just to see if it's possible to build all 3 versions from the
> same package without running into issues with koji builders running out of
> memory? It's fine to just '%if 0' it out afterwards if you don't want to
> actually ship it yet. It's really up to you how prudent you want to be; we
> can always split this up afterwards again if koji can't handle building it.

Discussion in https://pagure.io/releng/issue/10909

I'm beginning to suspect the number of builds does not actually matter, and that we've just caught the infrastructure at a bad time. But I'm not certain.

Comment 11 Michael Catanzaro 2022-07-24 15:01:35 UTC

Successful scratch build with all three builds enabled: https://koji.fedoraproject.org/koji/taskinfo?taskID=89880712. It took 36 hours total due to temporary infrastructure issues. Going forward, after Kevin made some configuration changes, it looks like each build will require approximately 20 hours (the time required to build on aarch64). That's slow, but it should drop down to 13-14 hours in Fedora 39 after we get rid of webkit2gtk4.0. Waiting is well worth the benefit of having only one source package to maintain.

Comment 12 Kalev Lember 2022-07-24 19:59:01 UTC

Okay! Looks good to me then. Thanks for sorting out the builder issues with infra.

Obsoletes and provides for the rename all look good, and otherwise the package is pretty much the same as the existing webkitgtk3 package.

Here is the rpmlint output for completeness sake:

$ rpmlint *
=================================================================================== rpmlint session starts ===================================================================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 15

webkit2gtk4.1.x86_64: W: no-manual-page-for-binary WebKitWebDriver
webkit2gtk5.0.x86_64: W: no-manual-page-for-binary WebKitWebDriver
javascriptcoregtk4.0.x86_64: W: no-documentation
javascriptcoregtk4.0-devel.x86_64: W: no-documentation
javascriptcoregtk4.1.x86_64: W: no-documentation
javascriptcoregtk4.1-devel.x86_64: W: no-documentation
javascriptcoregtk5.0.x86_64: W: no-documentation
javascriptcoregtk5.0-devel.x86_64: W: no-documentation
webkit2gtk4.0.x86_64: W: no-documentation
webkit2gtk4.0-devel.x86_64: W: no-documentation
webkit2gtk4.1.x86_64: W: no-documentation
webkit2gtk4.1-devel.x86_64: W: no-documentation
webkit2gtk5.0.x86_64: W: no-documentation
webkit2gtk5.0-devel.x86_64: W: no-documentation
webkit2gtk4.0.x86_64: W: library-not-linked-against-libc /usr/lib64/webkit2gtk-4.0/injected-bundle/libwebkit2gtkinjectedbundle.so
webkit2gtk4.1.x86_64: W: library-not-linked-against-libc /usr/lib64/webkit2gtk-4.1/injected-bundle/libwebkit2gtkinjectedbundle.so
webkit2gtk5.0.x86_64: W: library-not-linked-against-libc /usr/lib64/webkit2gtk-5.0/injected-bundle/libwebkit2gtkinjectedbundle.so
webkit2gtk4.0-doc.noarch: E: files-duplicated-waste 107957
webkit2gtk4.1-doc.noarch: E: files-duplicated-waste 107957
webkit2gtk5.0-doc.noarch: E: files-duplicated-waste 107957
webkit2gtk4.0.x86_64: W: files-duplicate /usr/share/licenses/webkit2gtk4.0/Source.WTF.wtf.dtoa.LICENSE /usr/share/licenses/webkit2gtk4.0/Source.WTF.wtf.dtoa.COPYING
webkit2gtk4.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.0/fonts.css /usr/share/gtk-doc/html/javascriptcoregtk-4.0/fonts.css:/usr/share/gtk-doc/html/webkit2gtk-4.0/fonts.css
webkit2gtk4.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.0/fzy.js /usr/share/gtk-doc/html/javascriptcoregtk-4.0/fzy.js:/usr/share/gtk-doc/html/webkit2gtk-4.0/fzy.js
webkit2gtk4.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.0/go-up-symbolic.png /usr/share/gtk-doc/html/javascriptcoregtk-4.0/go-up-symbolic.png:/usr/share/gtk-doc/html/webkit2gtk-4.0/go-up-symbolic.png
webkit2gtk4.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.0/main.js /usr/share/gtk-doc/html/javascriptcoregtk-4.0/main.js:/usr/share/gtk-doc/html/webkit2gtk-4.0/main.js
webkit2gtk4.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.0/search.js /usr/share/gtk-doc/html/javascriptcoregtk-4.0/search.js:/usr/share/gtk-doc/html/webkit2gtk-4.0/search.js
webkit2gtk4.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.0/solarized-dark.css /usr/share/gtk-doc/html/javascriptcoregtk-4.0/solarized-dark.css:/usr/share/gtk-doc/html/webkit2gtk-4.0/solarized-dark.css
webkit2gtk4.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.0/solarized-light.css /usr/share/gtk-doc/html/javascriptcoregtk-4.0/solarized-light.css:/usr/share/gtk-doc/html/webkit2gtk-4.0/solarized-light.css
webkit2gtk4.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.0/style.css /usr/share/gtk-doc/html/javascriptcoregtk-4.0/style.css:/usr/share/gtk-doc/html/webkit2gtk-4.0/style.css
webkit2gtk4.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.0/urlmap.js /usr/share/gtk-doc/html/webkit2gtk-4.0/urlmap.js
webkit2gtk4.1.x86_64: W: files-duplicate /usr/share/licenses/webkit2gtk4.1/Source.WTF.wtf.dtoa.LICENSE /usr/share/licenses/webkit2gtk4.1/Source.WTF.wtf.dtoa.COPYING
webkit2gtk4.1-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.1/fonts.css /usr/share/gtk-doc/html/javascriptcoregtk-4.1/fonts.css:/usr/share/gtk-doc/html/webkit2gtk-4.1/fonts.css
webkit2gtk4.1-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.1/fzy.js /usr/share/gtk-doc/html/javascriptcoregtk-4.1/fzy.js:/usr/share/gtk-doc/html/webkit2gtk-4.1/fzy.js
webkit2gtk4.1-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.1/go-up-symbolic.png /usr/share/gtk-doc/html/javascriptcoregtk-4.1/go-up-symbolic.png:/usr/share/gtk-doc/html/webkit2gtk-4.1/go-up-symbolic.png
webkit2gtk4.1-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.1/main.js /usr/share/gtk-doc/html/javascriptcoregtk-4.1/main.js:/usr/share/gtk-doc/html/webkit2gtk-4.1/main.js
webkit2gtk4.1-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.1/search.js /usr/share/gtk-doc/html/javascriptcoregtk-4.1/search.js:/usr/share/gtk-doc/html/webkit2gtk-4.1/search.js
webkit2gtk4.1-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.1/solarized-dark.css /usr/share/gtk-doc/html/javascriptcoregtk-4.1/solarized-dark.css:/usr/share/gtk-doc/html/webkit2gtk-4.1/solarized-dark.css
webkit2gtk4.1-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.1/solarized-light.css /usr/share/gtk-doc/html/javascriptcoregtk-4.1/solarized-light.css:/usr/share/gtk-doc/html/webkit2gtk-4.1/solarized-light.css
webkit2gtk4.1-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.1/style.css /usr/share/gtk-doc/html/javascriptcoregtk-4.1/style.css:/usr/share/gtk-doc/html/webkit2gtk-4.1/style.css
webkit2gtk4.1-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.1/urlmap.js /usr/share/gtk-doc/html/webkit2gtk-4.1/urlmap.js
webkit2gtk5.0.x86_64: W: files-duplicate /usr/share/licenses/webkit2gtk5.0/Source.WTF.wtf.dtoa.LICENSE /usr/share/licenses/webkit2gtk5.0/Source.WTF.wtf.dtoa.COPYING
webkit2gtk5.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-5.0/fonts.css /usr/share/gtk-doc/html/javascriptcoregtk-5.0/fonts.css:/usr/share/gtk-doc/html/webkit2gtk-5.0/fonts.css
webkit2gtk5.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-5.0/fzy.js /usr/share/gtk-doc/html/javascriptcoregtk-5.0/fzy.js:/usr/share/gtk-doc/html/webkit2gtk-5.0/fzy.js
webkit2gtk5.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-5.0/go-up-symbolic.png /usr/share/gtk-doc/html/javascriptcoregtk-5.0/go-up-symbolic.png:/usr/share/gtk-doc/html/webkit2gtk-5.0/go-up-symbolic.png
webkit2gtk5.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-5.0/main.js /usr/share/gtk-doc/html/javascriptcoregtk-5.0/main.js:/usr/share/gtk-doc/html/webkit2gtk-5.0/main.js
webkit2gtk5.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-5.0/search.js /usr/share/gtk-doc/html/javascriptcoregtk-5.0/search.js:/usr/share/gtk-doc/html/webkit2gtk-5.0/search.js
webkit2gtk5.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-5.0/solarized-dark.css /usr/share/gtk-doc/html/javascriptcoregtk-5.0/solarized-dark.css:/usr/share/gtk-doc/html/webkit2gtk-5.0/solarized-dark.css
webkit2gtk5.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-5.0/solarized-light.css /usr/share/gtk-doc/html/javascriptcoregtk-5.0/solarized-light.css:/usr/share/gtk-doc/html/webkit2gtk-5.0/solarized-light.css
webkit2gtk5.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-5.0/style.css /usr/share/gtk-doc/html/javascriptcoregtk-5.0/style.css:/usr/share/gtk-doc/html/webkit2gtk-5.0/style.css
webkit2gtk5.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-5.0/urlmap.js /usr/share/gtk-doc/html/webkit2gtk-5.0/urlmap.js
javascriptcoregtk4.0-devel.x86_64: E: description-line-too-long The javascriptcoregtk4.0-devel package contains libraries, build data, and header
javascriptcoregtk4.0-devel.x86_64: E: description-line-too-long files for developing applications that use JavaScript engine from webkit2gtk-4.0.
javascriptcoregtk4.1-devel.x86_64: E: description-line-too-long The javascriptcoregtk4.1-devel package contains libraries, build data, and header
javascriptcoregtk4.1-devel.x86_64: E: description-line-too-long files for developing applications that use JavaScript engine from webkit2gtk-4.1.
javascriptcoregtk5.0-devel.x86_64: E: description-line-too-long The javascriptcoregtk5.0-devel package contains libraries, build data, and header
javascriptcoregtk5.0-devel.x86_64: E: description-line-too-long files for developing applications that use JavaScript engine from webkit2gtk-5.0.
webkit2gtk4.0.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/1d/058cfee0aebc7c9bfd53d6e735382fe4763e29 ../../../../usr/libexec/webkit2gtk-4.0/MiniBrowser
webkit2gtk4.0.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/74/d4a813fdc6f62850a9237e4cde25cfc4b334b0 ../../../../usr/libexec/webkit2gtk-4.0/jsc
webkit2gtk4.1.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/63/1f5a3a69d3a27d8886308c90c56aa42e9fbe74 ../../../../usr/libexec/webkit2gtk-4.1/jsc
webkit2gtk4.1.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/6b/9e89b3b81c63f6d5dc627ba62774721ddede18 ../../../../usr/libexec/webkit2gtk-4.1/MiniBrowser
webkit2gtk5.0.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/14/9a285a9aa72e26215f9aa0e69dcf21e162a1d7 ../../../../usr/libexec/webkit2gtk-5.0/jsc
webkit2gtk5.0.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/86/81f68b20aab7d65e5da6529864a25ae770f70b ../../../../usr/libexec/webkit2gtk-5.0/MiniBrowser
================================================== 15 packages and 0 specfiles checked; 9 errors, 53 warnings, 9 badness; has taken 15.7 s ===================================================


APPROVED

Comment 13 Kalev Lember 2022-07-24 20:00:02 UTC

I believe the next step is to request webkitgtk package unretirement in releng pagure instance.

Comment 14 Michael Catanzaro 2022-07-24 20:14:43 UTC

https://pagure.io/releng/issue/10919

Comment 15 Michael Catanzaro 2022-08-04 21:40:28 UTC

I will now begin importing the package to: https://src.fedoraproject.org/rpms/webkitgtk/

Thanks everyone!