Bug 2109341

I'd like to see this one packaged! Version 12.13.1 was just released. Please let me know if I can help. 😉

mock fails to build. Partially due to missing python3-trustme. Another reason for the %check failures seems to be https://docs.pytest.org/en/stable/deprecations.html#pytest-plugins-in-non-top-level-conftest-files

Maybe version 12.13.1 fixed this?

Major: feel free to post a fixed srpm/spec file - I am trying to not make changes so I can remain an unbiased reviewer, but I'm sure my collegue Roman wouldn't mind you helping either (things were stalled due to me being away for two weeks)

I can take a look tomorrow most likely. I maintain about 100 Azure-related packages right now and I've found most of the quirks. 🙃

I have created a new spec file and src rpm based on the latest version of azure-storage-blob 12.13.1. 
I have also decided to use the tar file from github only as that is needed to run the test.

Spec URL: https://rommell.fedorapeople.org/python-azure-storage-blob/python-azure-storage-blob.spec
SRPM URL: https://rommell.fedorapeople.org/python-azure-storage-blob/python-azure-storage-blob-12.13.1-1.fc37.src.rpm

Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=90690596

Package not approved :/

I mailed you a spec file that I think works better, but will require
to grab those files needed for testing straight from github without
pulling in the giant entire azure python sdk ?
I think for now it is fine to skip the tests / %check for the initial
package with a note in %check about this

- You are calling pip install within the spec file, this is not allowed
- There is vcrpy-setup.diff but no link to an upstream PR. The description
  comment is a bit terse to understand what's going on. Would be nice to
  improve but not a blocker for review.
- Owning a directory another package owns seems common for all the
  azure packages, so okay :/
- This package is pulling from github where all the other azure python
  packages pull from pypi. The latter is better as you only download
  the single module instead of the entire azure tar ball.
- Package contains no bundled libraries without FPC exception.
  It does contain the _entire_ sdk, of which 99.9% is disgarded.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License", "*No copyright* GNU
     Lesser General Public License", "*No copyright* [generated file]",
     "*No copyright* MIT License", "Apache License 2.0", "*No copyright*
     Apache License 2.0". 12351 files have unknown license. Detailed output
     of licensecheck in /home/paul.wouters/2109341-python-azure-storage-
     blob/licensecheck.txt
[!]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/python3.11/site-
     packages/azure(python3-azure-mgmt-batchai, python3-azure-mgmt-
     marketplaceordering, python3-azure-mgmt-iothub, python3-azure-mgmt-
     recoveryservicesbackup, python3-azure-keyvault-keys, python3-azure-
     mgmt-botservice, python3-azure-mgmt-trafficmanager, python3-azure-
     mgmt-network, python3-azure-synapse-artifacts, python3-azure-datalake-
     store, python3-azure-mgmt-containerinstance, python3-azure-mgmt-
     hdinsight, python3-azure-graphrbac, python3-azure-mgmt-monitor,
     python3-azure-appconfiguration, python3-azure-mgmt-cosmosdb,
     python3-azure-keyvault-administration, python3-azure-mgmt-billing,
     python3-azure-mgmt-cognitiveservices, python3-azure-mgmt-
     servicelinker, python3-azure-identity, python3-azure-mgmt-
     containerregistry, python3-azure-mgmt-web, python3-azure-mgmt-dns,
     python3-azure-mgmt-sql, python3-azure-mgmt-policyinsights,
     python3-azure-mgmt-authorization, python3-azure-mgmt-msi,
     python3-azure-mgmt-servicefabric, python3-azure-mgmt-
     deploymentmanager, python3-azure-mgmt-azurestackhci, python3-azure-
     mgmt-databoxedge, python3-azure-mgmt-security, python3-azure-mgmt-
     devtestlabs, python3-azure-mgmt-servicefabricmanagedclusters,
     python3-azure-mgmt-batch, python3-azure-mgmt-datamigration,
     python3-azure-mgmt-recoveryservices, python3-azure-mgmt-eventgrid,
     python3-azure-mgmt-managedservices, python3-azure-mgmt-keyvault,
     python3-azure-mgmt-signalr, python3-azure-mgmt-redhatopenshift,
     python3-azure-mgmt-extendedlocation, python3-azure-mgmt-iotcentral,
     python3-azure-mgmt-resource, python3-azure-mgmt-redis, python3-azure-
     mgmt-eventhub, python3-azure-core, python3-azure-mgmt-compute,
     python3-azure-cosmos, python3-azure-mgmt-cdn, python3-azure-synapse-
     spark, python3-azure-mgmt-reservations, python3-azure-mgmt-search,
     python3-azure-mgmt-iothubprovisioningservices, python3-azure-keyvault-
     secrets, python3-azure-mgmt-subscription, python3-azure-data-tables,
     python3-azure-mgmt-applicationinsights, python3-azure-common,
     python3-azure-multiapi-storage, python3-azure-batch, python3-azure-
     mgmt-imagebuilder, python3-azure-mgmt-kusto, python3-azure-mgmt-maps,
     python3-azure-mgmt-containerservice, python3-azure-synapse-
     accesscontrol, azure-cli, python3-azure-mgmt-privatedns,
     python3-azure-synapse-managedprivateendpoints, python3-azure-storage-
     common, python3-azure-mgmt-appconfiguration, python3-azure-mgmt-core,
     python3-azure-mgmt-netapp, python3-azure-mgmt-advisor, python3-azure-
     mgmt-managementgroups, python3-azure-mgmt-media, python3-azure-mgmt-
     rdbms, python3-azure-mgmt-synapse, python3-azure-mgmt-loganalytics,
     python3-azure-keyvault-certificates, python3-azure-mgmt-servicebus,
     python3-azure-mgmt-sqlvirtualmachine, python3-azure-servicebus,
     python3-azure-mgmt-apimanagement, python3-azure-mgmt-hybridcompute,
     python3-azure-mgmt-storage), /usr/lib/python3.11/site-
     packages/azure/storage(python3-azure-storage-common)
[!]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Sources contain only permissible code or content.
     (don't know as it is all of azure sdk - probably though)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[!]: Package complies to the Packaging Guidelines
     (calls pip in spec file)
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[-]: Package meets the Packaging Guidelines::Python
     (not due to calling pip instal)
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
     (but included patch not needed if using pypi style spec file)
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Cannot parse rpmlint output:


Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Source checksums
----------------
https://github.com/Azure/azure-sdk-for-python/archive/refs/tags/azure-storage-blob_12.13.1.tar.gz :
  CHECKSUM(SHA256) this package     : db18f0da6824d34efc399e0c27c24da374a6298f3587bf8a72580203fdc2c96d
  CHECKSUM(SHA256) upstream package : db18f0da6824d34efc399e0c27c24da374a6298f3587bf8a72580203fdc2c96d


Requires
--------
python3-azure-storage-blob (rpmlib, GLIBC filtered):
    (python3.11dist(azure-core) < 2~~ with python3.11dist(azure-core) >= 1.23.1)
    python(abi)
    python3.11dist(cryptography)
    python3.11dist(msrest)



Provides
--------
python3-azure-storage-blob:
    python-azure-storage-blob
    python3-azure-storage-blob
    python3.11-azure-storage-blob
    python3.11dist(azure-storage-blob)
    python3dist(azure-storage-blob)



Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07
Command line :/usr/bin/fedora-review -b 2109341
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, Python
Disabled plugins: R, Ocaml, C/C++, SugarActivity, Haskell, fonts, Perl, Java, PHP
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

I have upload the new spec file to the same url and created a new srcrpm


Spec URL: https://rommell.fedorapeople.org/python-azure-storage-blob/python-azure-storage-blob.spec
SRPM URL: https://rommell.fedorapeople.org/python-azure-storage-blob/python-azure-storage-blob-12.13.1-1.fc37.src.rpm

Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=90951961

I also have working copr build https://copr.fedorainfracloud.org/coprs/rommell/python-azure-storage-blob/build/4743731/

thanks for addressing the issues. Package is APPROVED.

Note rpmlint does claim some files are listed twice, but since you are using all the proper macros, this would be a bug in either rpmlint or the macros, not this pacakge:

 rpmlint /home/paul.wouters/SRPMS/python-azure-storage-blob-12.13.1-1.fc36.src.rpm /home/paul.wouters/RPMS/noarch/python3-azure-storage-blob-12.13.1-1.fc36.noarch.rpm
============================================= rpmlint session starts =============================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 2

python3-azure-storage-blob.noarch: W: files-duplicate /usr/lib/python3.10/site-packages/azure/storage/blob/_generated/aio/__init__.py /usr/lib/python3.10/site-packages/azure/storage/blob/_generated/__init__.py
python3-azure-storage-blob.noarch: W: files-duplicate /usr/lib/python3.10/site-packages/azure/storage/blob/_generated/aio/_patch.py /usr/lib/python3.10/site-packages/azure/storage/blob/_generated/_patch.py
python3-azure-storage-blob.noarch: W: files-duplicate /usr/lib/python3.10/site-packages/azure/storage/blob/_generated/operations/__init__.py /usr/lib/python3.10/site-packages/azure/storage/blob/_generated/aio/operations/__init__.py
python3-azure-storage-blob.noarch: W: files-duplicate /usr/lib/python3.10/site-packages/azure/storage/blob/_generated/operations/_patch.py /usr/lib/python3.10/site-packages/azure/storage/blob/_generated/aio/operations/_patch.py:/usr/lib/python3.10/site-packages/azure/storage/blob/_generated/models/_patch.py
============== 2 packages and 0 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken 0.7 s ==============

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-azure-storage-blob

FEDORA-2022-1c6699ac16 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-1c6699ac16

FEDORA-2022-6e214bc914 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-6e214bc914

FEDORA-2022-6e214bc914 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-6e214bc914 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-6e214bc914

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2022-1c6699ac16 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-1c6699ac16 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-1c6699ac16

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2022-c654d019fc has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-c654d019fc

FEDORA-2022-c654d019fc has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2022-1c6699ac16 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2022-6e214bc914 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.