Bug 2109538

Summary:	Nutanix platform validations run at `create manifests` stage
Product:	OpenShift Container Platform	Reporter:	Vadim Rutkovsky <vrutkovs>
Component:	Installer	Assignee:	OCP Installer <ocp-installer>
Installer sub component:	openshift-installer	QA Contact:	gaoshang <sgao>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	high
Priority:	unspecified
Version:	4.11
Target Milestone:	---
Target Release:	4.12.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-01-17 19:53:12 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Vadim Rutkovsky 2022-07-21 13:57:04 UTC

Version:

$ openshift-install version
4.11.0-rc2

Platform:

Nutanix

On `openshift-installer create manifests` stage a connection to Prism is made (see https://github.com/openshift/installer/blob/master/pkg/asset/installconfig/nutanix/validation.go#L15-L36=)

This make generating manifests separately impossible, which breaks Assisted Installer flow. Instead of storing sensitive user information, Assisted Installer sets fake details in install-config.yaml and asks user to update these after installation has completed. 

With validation happening on `openshift-install create manifests` phase installation process can't start with invalid credentials.

Please move this validation to ValidateForProvisioning, similar to vSphere

Comment 3 gaoshang 2022-08-24 14:41:54 UTC

This bug has been verified on OCP 4.12.0-0.nightly-2022-08-23-223922 and passed, thanks.

Steps:

1, Create install-config.yaml with fake prismElements uuid
2, Run openshift-install create manifests, check installation process can start with invalid credentials

[root@preserve-sgao nutanix]# ./openshift-install create manifests --dir cluster
INFO Consuming Install Config from target directory 
FATAL failed to fetch Common Manifests: failed to fetch dependency of "Common Manifests": failed to generate asset "Infrastructure Config": fail to find the Prism Element (cluster) with uuid fake: status: 400 BAD REQUEST, error-response: { 
FATAL   "api_version": "3.1",                      
FATAL   "code": 400,                               
FATAL   "kind": "cluster",                         
FATAL   "message_list": [                          
FATAL     {                                        
FATAL       "message": "Invalid UUID passed. fake", 
FATAL       "reason": "INVALID_UUID"               
FATAL     }                                        
FATAL   ],                                         
FATAL   "state": "ERROR"                           
FATAL }                                            
[root@preserve-sgao nutanix]# ls cluster/
openshift

Comment 6 errata-xmlrpc 2023-01-17 19:53:12 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.12.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:7399