Bug 2109838

Summary: Review Request: golang-github-oracle-oci-sdk-60 - Go SDK for Oracle Cloud Infrastructure
Product: [Fedora] Fedora Reporter: Mark E. Fuller <mark.e.fuller>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-08-23 00:45:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 201449    

Description Mark E. Fuller 2022-07-22 09:40:55 UTC
Spec URL: https://fuller.fedorapeople.org/golang-github-oracle-oci-sdk-60.spec
SRPM URL: https://fuller.fedorapeople.org/golang-github-oracle-oci-sdk-60-60.0.0-1.fc37.src.rpm
Description: Go SDK for Oracle Cloud Infrastructure
Fedora Account System Username: fuller

Comment 1 Package Review 2023-07-23 00:45:34 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 2 Robert-André Mauchin 🐧 2023-07-30 18:14:23 UTC
 - Update to 65.45.0

 - Update to SPDX licensing. Also it is dual licensed with UPL

 - Don't disable the entire check section

 - don't leave this if you are not packaging the library :

%files
%license LICENSE.txt NOTICE.txt
%doc example CHANGELOG.md CONTRIBUTING.md README.md THIRD_PARTY_LICENSES.txt
%doc THIRD_PARTY_LICENSES_DEV.txt

 - use latest go2rpm for you spec:

# Generated by go2rpm 1.9.0
%bcond_without check
%global debug_package %{nil}

# https://github.com/oracle/oci-go-sdk
%global goipath         github.com/oracle/oci-go-sdk/v65
Version:                65.45.0

%gometa -f

%global common_description %{expand:
Go SDK for Oracle Cloud Infrastructure.}

%global golicenses      LICENSE.txt NOTICE.txt
%global godocs          example CHANGELOG.md CONTRIBUTING.md README.md\\\
                        SECURITY.md

Name:           %{goname}
Release:        %autorelease
Summary:        Go SDK for Oracle Cloud Infrastructure

License:        Apache-2.0 OR UPL-1.0
URL:            %{gourl}
Source:         %{gosource}

%description %{common_description}

%gopkg

%prep
%goprep
%autopatch -p1

%generate_buildrequires
%go_generate_buildrequires

%install
%gopkginstall
%if %{with check}
%check
for test in "TestUploadFileMultiparts" \
            "TestUploadStreamMultiparts" \
            "TestUploadReqest_initDefaultValues" \
            "TestUploadFileReqest_initDefaultValues" \
            "TestUploadManager_UploadFile" \
            "TestUploadManager_UploadStream" \
; do
awk -i inplace '/^func.*'"$test"'\(/ { print; print "\tt.Skip(\"disabled failing test\")"; next}1' $(grep -rl $test)
done
%gocheck
%endif

%gopkgfiles

%changelog
%autochangelog



Needinfo when you have fixed the issues.

Comment 3 Package Review 2023-08-23 00:45:26 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.

Comment 4 Red Hat Bugzilla 2023-12-22 04:25:06 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days