Bug 2109957

Summary:	OVS incorrectly reporting userspace queued packets as dropped
Product:	Red Hat Enterprise Linux 8	Reporter:	Mike Pattrick <mpattric>
Component:	kernel	Assignee:	Mike Pattrick <mpattric>
kernel sub component:	OVS	QA Contact:	qding
Status:	CLOSED MIGRATED	Docs Contact:
Severity:	low
Priority:	unspecified	CC:	jmaxwell, network-qe, pvalerio
Version:	8.5	Keywords:	MigratedToJIRA
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-09-21 12:31:20 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Mike Pattrick 2022-07-22 14:22:59 UTC

Description of problem:

In bz 2099811 it was reported that frames queued for userspace upcall were being reported as dropped in queue_userspace_packet(), even in cases where there was no error.

> 560 ▹       err = genlmsg_unicast(ovs_dp_get_net(dp), user_skb,
> upcall_info->portid);↩ <---- this returns 0
> 561 ▹       user_skb = NULL;↩
> 562 out:↩
> 563 ▹       if (err)↩
> 564 ▹       ▹       skb_tx_error(skb);↩
> 565 ▹       kfree_skb(user_skb);↩
> 566 ▹       kfree_skb(nskb);↩ <---- and it call kfree_skb() instead of
> __kfree_skb() here incorrectly (this is a minor bug)
> 567 ▹       return err;↩
> 568 }↩

Comment 1 Mike Pattrick 2022-07-25 16:18:54 UTC

This may be a new issue, or may be unrelated, but in an attempt to reproduce I also noticed that ICMP packets are reported as dropped when they are not:

> 1 drops at icmp_rcv+1e5 (0xffffffff81bbb515) [software]

This is reported in a different location, however, the symptom is the same.

Comment 2 RHEL Program Management 2023-09-21 11:03:41 UTC

Issue migration from Bugzilla to Jira is in process at this time. This will be the last message in Jira copied from the Bugzilla bug.

Comment 3 RHEL Program Management 2023-09-21 12:31:20 UTC

This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there.

Due to differences in account names between systems, some fields were not replicated.  Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information.

To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "RHEL-" followed by an integer.  You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like:

"Bugzilla Bug" = 1234567

In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information.

Comment 4 Flavio Leitner 2024-03-12 14:51:25 UTC

*** Bug 2110268 has been marked as a duplicate of this bug. ***