Bug 2109986

Summary:	[machines] 'User login' in 'Create VM' dialog is not clear when changing 'Download an OS' to 'Cloud base image'
Product:	Red Hat Enterprise Linux 8	Reporter:	YunmingYang <yunyang>
Component:	cockpit-appstream	Assignee:	Simon Kobyda <skobyda>
Status:	CLOSED ERRATA	QA Contact:	YunmingYang <yunyang>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	8.7	CC:	mpitt, qzhang, wshi, xchen, ymao
Target Milestone:	rc	Keywords:	Triaged
Target Release:	8.8	Flags:	pm-rhel: mirror+
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	cockpit-appstream-279-1.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-05-16 08:35:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description YunmingYang 2022-07-22 15:51:39 UTC

Description of problem:
Open 'Create VM' dialog, then input an OS. After that switch to the 'Automation' tab, then set 'Root password', 'User password' and 'User login'. Then change 'Download an OS' to 'Cloud base image', 'Root password' and 'User password' is clear, but 'User login' not

Version-Release number of selected components (if applicable):
cockpit-machines-272-1.el8.noarch
cockpit-272-2.el8.x86_64
libvirt-dbus-1.3.0-2.module+el8.6.0+12861+13975d62.x86_64

How reproducible:
100%

Steps to Reproduce:
1 Open 'Create VM' dialog
2 Input an OS(like Fedora 34)
3 switch to the 'Automation' tab, then set 'Root password', 'User password' and 'User login'
4 change 'Download an OS' to 'Cloud base image'

Actual results:
1 After step 4, Both 'Root password' and 'User password' are clear, but 'User login' not

Expected results:
1 After step 4, All of 'Root password', 'User password' and 'User login' should be clear

Additional info:

Comment 1 Simon Kobyda 2022-09-01 12:54:01 UTC

I believe the ideal behaviour is the other way around, that root and user password should not be cleared/reset when user switches from "Download OS" to "Cloud base image" and vice versa.

Sent PR upstream: https://github.com/cockpit-project/cockpit-machines/pull/803

Comment 2 Martin Pitt 2022-09-02 05:14:36 UTC

Fix landed upstream.

Comment 3 YunmingYang 2022-10-19 02:57:54 UTC

Pre-verify with follow versions:
cockpit-276.1-1.el8.x86_64
cockpit-machines-276-1.el8.noarch
libvirt-dbus-1.3.0-2.module+el8.7.0+16689+53d59bc2.x86_64

Steps:
1 Open 'Create VM' dialog
2 Input an OS(like Fedora 34)
3 Switch to the 'Automation' tab, then set 'Root password', 'User password' and 'User login'
4 Change 'Download an OS' to 'Cloud base image'

Results:
1 After step 4, 'Root password', 'User password' and 'User login' is not changed

Comment 5 Xianghua Chen 2022-11-17 08:02:46 UTC

As the ITM Is the deadline for verification and we still not have the build on RHEL8.8, I change the ITM 2 weeks later in case we would lose the release+.
Feel free to change it per your estimation.

Comment 8 YunmingYang 2022-11-30 12:52:06 UTC

Test Versions:
cockpit-279-1.el8.x86_64
cockpit-machines-279-1.el8.noarch
libvirt-dbus-1.3.0-2.module+el8.8.0+16781+9f4724c2.x86_64


Test Steps:
1 Open 'Create VM' dialog
2 Input an OS(like Fedora 34)
3 Switch to the 'Automation' tab, then set 'Root password', 'User password' and 'User login'
4 Change 'Download an OS' to 'Cloud base image', then check 'Root password', 'User password' and 'User login' in 'Automation' tab

Test Results:
1 After step 4, 'Root password', 'User password' and 'User login' is not changed


According to the results, move status to VERIFIED.

Comment 12 errata-xmlrpc 2023-05-16 08:35:46 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (cockpit-appstream bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2821