Bug 2111228

Summary:	[ODF MS] Fresh Deployment with provider addon v2.0.4 is failed: spec.remoteWrite.oauth2.tokenUrl: Invalid value
Product:	[Red Hat Storage] Red Hat OpenShift Data Foundation	Reporter:	suchita <sgatfane>
Component:	odf-managed-service	Assignee:	Kaustav Majumder <kmajumde>
Status:	CLOSED CURRENTRELEASE	QA Contact:	suchita <sgatfane>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.10	CC:	aeyal, kmajumde, ocs-bugs, odf-bz-bot, rchikatw
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	v2.04	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-01-23 08:44:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description suchita 2022-07-26 19:10:33 UTC

Description of problem:

Appliance mode fresh deployment addon status of provider is failed

Version-Release number of selected component (if applicable):
OCS-provider-qe Addon deployer version v2.0.4
openshift-v4.10.22


How reproducible:
2/2

Steps to Reproduce:
1. Deploy appliance mode provider with a
2.
3.

Actual results:Addon install status is Failed


Expected results: provider Addon should get installed successfully and have status ready 


Additional info:

root cause analyzed and discussed in gchat thread https://chat.google.com/room/AAAASHA9vWs/LkLDLWdnKAo

2022-07-26T12:10:19.923Z    ERROR    controllers.ManagedOCS    An error was encountered during reconcilePhases    {"error": "Failed to update Prometheus: Prometheus.monitoring.coreos.com \"managed-ocs-prometheus\" is invalid: spec.remoteWrite.oauth2.tokenUrl: Invalid value: \"\": spec.remoteWrite.oauth2.tokenUrl in body should be at least 1 chars long"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
    /tmp/go/ocs-osd-deployer/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:298
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
    /tmp/go/ocs-osd-deployer/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:253
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
    /tmp/go/ocs-osd-deployer/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:214
2022-07-26T12:10:19.930Z    ERROR    controller-runtime.manager.controller.managedocs    Reconciler error    {"reconciler group": "ocs.openshift.io", "reconciler kind": "ManagedOCS", "name": "managedocs", "namespace": "openshift-storage", "error": "Failed to update Prometheus: Prometheus.monitoring.coreos.com \"managed-ocs-prometheus\" is invalid: spec.remoteWrite.oauth2.tokenUrl: Invalid value: \"\": spec.remoteWrite.oauth2.tokenUrl in body should be at least 1 chars long"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
    /tmp/go/ocs-osd-deployer/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:253
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
    /tmp/go/ocs-osd-deployer/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:214

Comment 1 Filip Balák 2022-08-01 12:08:21 UTC

*** Bug 2111225 has been marked as a duplicate of this bug. ***

Comment 2 Filip Balák 2022-08-01 12:08:32 UTC

*** Bug 2111226 has been marked as a duplicate of this bug. ***

Comment 3 Kaustav Majumder 2022-08-02 07:41:45 UTC

The saas  template for the secret was incorrect resulting in the secret getting created in the addon namespace as incomplete. Fixing the saas template fixed the issue for upgraded and fresh installed clusters.
@suchita can you confim the same?

Comment 4 suchita 2022-08-04 11:03:02 UTC

After a Fix, Fesh deployment has processed successfully. 
Reference Jenkins Jobs: 
Provider :https://ocs4-jenkins-csb-odf-qe.apps.ocp-c1.prod.psi.redhat.com/job/qe-deploy-ocs-cluster/15274/
Consumer: https://ocs4-jenkins-csb-odf-qe.apps.ocp-c1.prod.psi.redhat.com/job/qe-deploy-ocs-cluster/15281/

Hence marking This BZ as verified.

Comment 12 Ritesh Chikatwar 2023-01-23 08:44:04 UTC

Closing the bug as it's fixed in v2.0.4 and verified by QA.