Bug 2112002

Summary: Add support for OCF 1.1 cluster properties
Product: Red Hat Enterprise Linux 8 Reporter: Tomas Jelinek <tojeline>
Component: pcsAssignee: Miroslav Lisik <mlisik>
Status: CLOSED ERRATA QA Contact: cluster-qe <cluster-qe>
Severity: medium Docs Contact:
Priority: medium    
Version: 8.0CC: cfeist, cluster-maint, cluster-qe, idevat, mlisik, mmazoure, mpospisi, nhostako, omular, tojeline
Target Milestone: rcKeywords: Triaged
Target Release: 8.8Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: pcs-0.10.15-1.el8 Doc Type: If docs needed, set a value
Doc Text:
Feature: Add support for OCF 1.1 format of cluster properties metadata. Reason: Enhance verification of new types. Result: Pcs property command now properly read metadata in new format and validate against it.
Story Points: ---
Clone Of: 2019464 Environment:
Last Closed: 2023-05-16 08:12:42 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2112003    

Description Tomas Jelinek 2022-07-28 15:17:01 UTC
+++ This bug was initially created as a clone of Bug #2019464 +++

In bz1281463, pacemaker have migrated cluster properties metadata to OCF 1.1 format. In order for pcs to still be able to validate cluster properties and their values, we need to use the new OCF 1.1 capable parser and update validators in pcs.

Comment 1 Miroslav Lisik 2022-11-16 16:01:16 UTC
Upstream commit: https://github.com/ClusterLabs/pcs/commit/bfc1d290909cd61dddc8d602ca92869c95697616
Updated commands:
  * pcs property set
  * pcs property unset

Property commands has been updated to be able properly read new OCF 1.1 format of properties metadata and validate against it.
Everything should work as before with additional validations.

Test:

[root@r8-node-01 pcs]# /usr/libexec/pacemaker/pacemaker-schedulerd metadata | grep \<version\>
  <version>1.1</version>


[root@r8-node-01 pcs]# pcs property set no-quorum-policy=unknown
Error: 'unknown' is not a valid no-quorum-policy value, use 'demote', 'freeze', 'ignore', 'stop', 'suicide', use --force to override
Error: Errors have occurred, therefore pcs is unable to continue
[root@r8-node-01 pcs]# pcs property set no-quorum-policy=unknown --force
Warning: 'unknown' is not a valid no-quorum-policy value, use 'demote', 'freeze', 'ignore', 'stop', 'suicide'
[root@r8-node-01 pcs]# pcs property config no-quorum-policy
Cluster Properties:
 no-quorum-policy: unknown


[root@r8-node-01 pcs]# pcs property set no-quorum-policy=freeze
[root@r8-node-01 pcs]# pcs property config no-quorum-policy
Cluster Properties:
 no-quorum-policy: freeze

Comment 2 Michal Pospisil 2022-11-24 16:52:48 UTC
DevTestResults:

[root@r08-08-a ~]# rpm -q pcs
pcs-0.10.15-1.el8.x86_64

[root@r08-08-a ~]# /usr/libexec/pacemaker/pacemaker-schedulerd metadata | grep \<version\>
 <version>1.1</version>

[root@r08-08-a ~]# pcs property set no-quorum-policy=unknown
Error: 'unknown' is not a valid no-quorum-policy value, use 'demote', 'freeze', 'ignore', 'stop', 'suicide', use --force to override
Error: Errors have occurred, therefore pcs is unable to continue

[root@r08-08-a ~]# pcs property set no-quorum-policy=unknown --force
Warning: 'unknown' is not a valid no-quorum-policy value, use 'demote', 'freeze', 'ignore', 'stop', 'suicide'

[root@r08-08-a ~]# pcs property config no-quorum-policy
Cluster Properties:
no-quorum-policy: unknown

[root@r08-08-a ~]# pcs property set no-quorum-policy=freeze

[root@r08-08-a ~]# pcs property config no-quorum-policy
Cluster Properties:
no-quorum-policy: freeze

Comment 9 errata-xmlrpc 2023-05-16 08:12:42 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (pcs bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2738