Bug 211242 (scribes-templates)
Summary: | Review Request: scribes-templates - Templates ("Snippets") for the Scribes text editor | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Peter Gordon <peter> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | mtasaka |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-10-20 01:03:14 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Peter Gordon
2006-10-18 01:29:14 UTC
1. Well, while writing %build section seems preferable even if it is empty, don't write %pre %preun.. etc if they are empty because writing "%post" (even if its content is empty) calls a shell (in this case, it is /bin/bash) without autual need and adds redundant "Requires: /bin/bash" to the rpm package. 2. The line: install -m 0644 %{SOURCE1} . Please keep timestamps, i.e. use "install -p" (or "cp -p"). 3. By the way, does upstream have a plan to change the numbering of "VERSION"? Usually writing date to version is not preferable. Spec: http://thecodergeek.com/downloads/fedora/scribes-templates.spec SRPM: http://thecodergeek.com/downloads/fedora/scribes-templates-20061017-2.src.rpm The first two issues I've fixed in release 2, linked above. > By the way, does upstream have a plan to change the numbering of > "VERSION"? Usually writing date to version is not preferable. Datestamps like this are the current plan (since they will feasibly not be updated quite as often as Scribes itself). Why are datestamps like this not preferred? (There really is no other specific versioning to it...) Thanks for your suggestions! (In reply to comment #2) > Why are datestamps like this not > preferred? (There really is no other specific versioning to it...) There are many cases that a source numbered by date means it is a pre-version and in that case the VERSION in spec file should have something like 0.%{date}. However, if it is not for this package, it is okay. --------------------------------------------------------------------- This package (scribes-templates) is APPROVED by me. Imported and built for devel. Thanks for the review! :) |