Bug 211256 (viaideinfo)
| Summary: | Review Request: viaideinfo - Displays information on connected VIA IDE controllers | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Gordon <peter> |
| Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-10-19 07:00:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Peter Gordon
2006-10-18 06:23:01 UTC
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
e436a580eb8a047a0551cb996b11e6f5 viaideinfo-0.4.tar.gz
e436a580eb8a047a0551cb996b11e6f5 viaideinfo-0.4.tar.gz.1
OK - Package has Exclusivearch
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane:
SHOULD Items:
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
OK - Should package latest version
Issues:
1. Since this package has
ExclusiveArch: %{ix86}
I assume none of the supported VIA chipsets are shipped on
x86_64?
Works fine on my firewall machine with a VT82C586A/B.
I don't see any blockers here at all, so this package is
APPROVED. Don't forget to close this review request with
NEXTRELEASE once it's been imported and built.
Consider reviewing another waiting package to help spread
out the reviewing load.
(In reply to comment #1) > 1. Since this package has > ExclusiveArch: %{ix86} > I assume none of the supported VIA chipsets are shipped on > x86_64? Daniel Drake, the upstream maintainer, is also the person who maintains the package in Gentoo's Portage. In that, it's keyworded as x86-only. I'll email him about that just to be sure, though. :) > Consider reviewing another waiting package to help spread > out the reviewing load. I really should. I'll see what I can get tomorrow after work. Importing now...thanks for the review! Imported, FC-5 branch requested, and devel build running on the build system. Thanks for the review! :) Please do not remove the blocker on FE-ACCEPT (In reply to comment #4) > Please do not remove the blocker on FE-ACCEPT Ack. Sorry about that; and thanks, Christian. (In reply to comment #5) > Ack. Sorry about that; and thanks, Christian. np :-) |