Bug 2112928

Summary:	GCP: Fix validation error message when no instance types returned
Product:	OpenShift Container Platform	Reporter:	OpenShift BugZilla Robot <openshift-bugzilla-robot>
Component:	Installer	Assignee:	Aditya Narayanaswamy <anarayan>
Installer sub component:	openshift-installer	QA Contact:	Jianli Wei <jiwei>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	low
Priority:	low	CC:	anarayan, padillon
Version:	4.10-rc3
Target Milestone:	---
Target Release:	4.11.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-09-12 10:14:28 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2102324
Bug Blocks:	2102363, 2112914

Comment 1 Patrick Dillon 2022-08-01 15:43:32 UTC

*** Bug 2112913 has been marked as a duplicate of this bug. ***

Comment 2 Jianli Wei 2022-08-02 03:14:32 UTC

Tested with the build having the PR https://github.com/openshift/installer/pull/6190 (see https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-launch-gcp-modern/1554281902796443648), and now reasonable error message is shown. 

$ openshift-install version
openshift-install 4.11.0-0.ci.test-2022-08-02-025606-ci-ln-q8lrilk-latest
built from commit a2837f73ef97bc6f59a20cbf1c2cc23d7d96e253
release image registry.build05.ci.openshift.org/ci-ln-q8lrilk/release@sha256:011dea82542df5be4b80b17c754633977e0c503fa615c0922062e33c24ceb430
release architecture amd64
$ yq-3.3.0 r work/install-config.yaml compute
- architecture: amd64
  hyperthreading: Enabled
  name: worker
  platform:
    gcp:
      osDisk:
        DiskSizeGB: 0
        diskType: ""
      type: e2-standard-4
  replicas: 3
$ yq-3.3.0 r work/install-config.yaml controlPlane
architecture: amd64
hyperthreading: Enabled
name: master
platform:
  gcp:
    osDisk:
      DiskSizeGB: 0
      diskType: ""
    type: e2-standard-4
replicas: 3
$ yq-3.3.0 r work/install-config.yaml platform
gcp:
  projectID: openshift-qe
  region: europe-west-8
$ 
$ openshift-install create install-config --dir work
INFO Credentials loaded from file "/home/fedora/.gcp/osServiceAccount.json" 
ERROR failed to fetch Install Config: failed to load asset "Install Config": failed to create install config: [platform.gcp.region: Invalid value: "europe-west-8": invalid region, <nil>: Internal error: failed to fetch instance types, this error usually occurs if the region is not found] 
$

Comment 4 Jianli Wei 2022-09-05 02:21:53 UTC

>Verified with 4.11.0-0.nightly-2022-09-02-184920.

$ openshift-install version
openshift-install 4.11.0-0.nightly-2022-09-02-184920
built from commit 25aa6a41b7ca1f5e9357f925ad82c237a7cbdc63
release image registry.ci.openshift.org/ocp/release@sha256:2a336f287520bbe724157fbe69c23eb96e9313e744e8e9e9820e00e3d3851251
release architecture amd64
$ 
$ yq-3.3.0 r work/install-config.yaml compute
- architecture: amd64
  hyperthreading: Enabled
  name: worker
  platform:
    gcp:
      osDisk:
        DiskSizeGB: 0
        diskType: ""
      type: e2-standard-4
  replicas: 2
$ yq-3.3.0 r work/install-config.yaml controlPlane
architecture: amd64
hyperthreading: Enabled
name: master
platform:
  gcp:
    osDisk:
      DiskSizeGB: 0
      diskType: ""
    type: e2-standard-4
replicas: 3
$ yq-3.3.0 r work/install-config.yaml platform
gcp:
  projectID: openshift-qe
  region: europe-west-8
$ 
$ openshift-install create install-config --dir work
INFO Credentials loaded from file "/home/fedora/.gcp/osServiceAccount.json" 
ERROR failed to fetch Install Config: failed to load asset "Install Config": failed to create install config: [platform.gcp.region: Invalid value: "europe-west-8": invalid region, <nil>: Internal error: failed to fetch instance types, this error usually occurs if the region is not found] 
$

Comment 7 errata-xmlrpc 2022-09-12 10:14:28 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.11.4 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:6376