Bug 2112941

Summary: rpcbind.socket dies upon try-restart, causing related services (e.g. ypbind) to become unavailable
Product: Red Hat Enterprise Linux 9 Reporter: Dave Wysochanski <dwysocha>
Component: nfs-utilsAssignee: Steve Dickson <steved>
Status: CLOSED ERRATA QA Contact: Yongcheng Yang <yoyang>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 9.0CC: xzhou, yieli, yoyang
Target Milestone: rcKeywords: Patch, Triaged
Target Release: ---Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: nfs-utils-2.5.4-15.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-11-15 11:22:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dave Wysochanski 2022-08-01 14:54:33 UTC 
This bug was initially created as a copy of Bug #2100395

I am copying this bug because: 



Description of problem:

Upon rpcbind package update the following command is issued from rpm scriptlet:
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------
systemctl try-restart rpcbind.service rpcbind.socket
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------

This ends up having the rpcbind.socket fail to start, because rpcbind.service is already active and also hijacked the sockets.

The journal shows some kind of race condition between the service and the socket:
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------
# journalctl -b -u rpcbind.service -u rpcbind.socket -o short-precise
-- Logs begin at Thu 2022-06-23 10:59:56 CEST, end at Thu 2022-06-23 11:01:01 CEST. --
Jun 23 11:00:00.387955 vm-rhel8 systemd[1]: Starting RPC Bind...
Jun 23 11:00:00.454849 vm-rhel8 systemd[1]: Started RPC Bind.
Jun 23 11:00:35.378595 vm-rhel8 systemd[1]: Stopping RPC Bind...
Jun 23 11:00:35.380285 vm-rhel8 systemd[1]: rpcbind.service: Succeeded.
Jun 23 11:00:35.380591 vm-rhel8 systemd[1]: Stopped RPC Bind.

Jun 23 11:00:35.381691 vm-rhel8 systemd[1]: Starting RPC Bind...

--> This is rpcbind.service restart

Jun 23 11:00:35.384161 vm-rhel8 systemd[1]: rpcbind.socket: Succeeded.
Jun 23 11:00:35.384504 vm-rhel8 systemd[1]: Closed RPCbind Server Activation Socket.
Jun 23 11:00:35.384525 vm-rhel8 systemd[1]: Stopping RPCbind Server Activation Socket.

--> This is rpcbind.socket restart, only the stop happens due to rpcbind.service hijacking the sockets

Jun 23 11:00:35.384595 vm-rhel8 systemd[1]: rpcbind.socket: Socket service rpcbind.service already active, refusing.
Jun 23 11:00:35.384618 vm-rhel8 systemd[1]: Failed to listen on RPCbind Server Activation Socket.
Jun 23 11:00:35.384656 vm-rhel8 systemd[1]: Dependency failed for RPC Bind.
Jun 23 11:00:35.384673 vm-rhel8 systemd[1]: rpcbind.service: Job rpcbind.service/start failed with result 'dependency>

# netstat -anlp | egrep -w "rpcbind|111"
tcp        0      0 0.0.0.0:111             0.0.0.0:*               LISTEN      1559/rpcbind        
tcp6       0      0 :::111                  :::*                    LISTEN      1559/rpcbind        
udp        0      0 0.0.0.0:111             0.0.0.0:*                           1559/rpcbind        
udp6       0      0 :::111                  :::*                                1559/rpcbind        
unix  2      [ ACC ]     STREAM     LISTENING     20232    1559/rpcbind         /run/rpcbind.sock

--> everything held by "rpcbind" instead of "systemd"
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------

Interestingly, when stracing *systemd*, I'm not able to reproduce, which seems to indicate there is some race.

Version-Release number of selected component (if applicable):

Up to rpcbind-1.2.5-8.el8.x86_64 included

How reproducible:

Always

Steps to Reproduce:
1. Execute "systemctl try-restart rpcbind.service rpcbind.socket"

Actual results:

Job for rpcbind.socket failed.
See "systemctl status rpcbind.socket" and "journalctl -xe" for details.
A dependency job for rpcbind.service failed. See 'journalctl -xe' for details.

Expected results:

No error
Comment 1 Dave Wysochanski 2022-08-01 15:02:22 UTC 
SteveD and QE please set milestones as needed - jsut setting to match the RHEL8 bug milestones.
Comment 2 Steve Dickson 2022-08-01 17:22:00 UTC 
commit 8a835cebb149ba2a54b6518722c79019cf8e3da4 (HEAD -> master, origin/master, origin/HEAD)
Author: Benjamin Coddington <bcodding>
Date:   Mon Aug 1 13:19:04 2022 -0400

    rpc-statd.service: Stop rpcbind and rpc.stat in an exit race
Comment 3 Yongcheng Yang 2022-08-19 09:20:16 UTC 
Verified in nfs-utils-2.5.4-15.el9

[root@fsqe-r430-02 ~]# rpm -q nfs-utils rpcbind
nfs-utils-2.5.4-15.el9.x86_64
rpcbind-1.2.6-2.el9.x86_64
[root@fsqe-r430-02 ~]# time systemctl try-restart rpcbind.service rpcbind.socket

real    0m0.014s
user    0m0.002s
sys     0m0.004s
[root@fsqe-r430-02 ~]# time systemctl try-restart rpcbind.service rpcbind.socket

real    0m0.012s
user    0m0.003s
sys     0m0.002s
[root@fsqe-r430-02 ~]# time systemctl try-restart rpcbind.service rpcbind.socket

real    0m0.013s
user    0m0.002s
sys     0m0.006s
[root@fsqe-r430-02 ~]# time systemctl restart rpcbind.socket

real    0m0.012s
user    0m0.005s
sys     0m0.003s
[root@fsqe-r430-02 ~]# time systemctl restart rpcbind.socket

real    0m0.012s
user    0m0.003s
sys     0m0.005s
[root@fsqe-r430-02 ~]# time systemctl restart rpcbind.socket

real    0m0.012s
user    0m0.005s
sys     0m0.003s
Comment 7 errata-xmlrpc 2022-11-15 11:22:03 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (nfs-utils bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:8376