Bug 2113135

Summary: bwm-ng: FTBFS in Fedora rawhide/f37
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: bwm-ngAssignee: Tim Orling <TicoTimo>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 37CC: i, jwakely, oliver, sven, TicoTimo
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: bwm-ng-0.6.3-1.fc38 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-03-11 03:09:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2117176, 2168842, 2045102    
Attachments:
Description Flags
build.log
none
root.log
none
state.log none

Description Fedora Release Engineering 2022-08-01 23:18:36 UTC
bwm-ng failed to build from source in Fedora rawhide/f37

https://koji.fedoraproject.org/koji/taskinfo?taskID=89758584


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild
Please fix bwm-ng at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
bwm-ng will be orphaned. Before branching of Fedora 38,
bwm-ng will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/

Comment 1 Fedora Release Engineering 2022-08-01 23:18:39 UTC
Created attachment 1900852 [details]
build.log

Comment 2 Fedora Release Engineering 2022-08-01 23:18:40 UTC
Created attachment 1900853 [details]
root.log

file root.log too big, will only attach last 32768 bytes

Comment 3 Fedora Release Engineering 2022-08-01 23:18:42 UTC
Created attachment 1900854 [details]
state.log

Comment 4 Ben Cotton 2022-08-09 13:24:15 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 37 development cycle.
Changing version to 37.

Comment 5 Jonathan Wakely 2023-02-02 12:18:40 UTC
output.c: In function 'print_header':
output.c:156:13: error: format not a string literal and no format arguments [-Werror=format-security]
  156 |             wprintw(stdscr,show_all_if2str());
      |             ^~~~~~~


Also:

input/proc_diskstats.c: In function 'get_disk_stats_proc':
input/proc_diskstats.c:164:41: warning: pointer 'buffer_67' used after 'free' [-Wuse-after-free]
  164 |                                         deinit(1, "wrong format of procfile. %i: %s\n",n,buffer);
      |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
input/proc_diskstats.c:163:41: note: call to 'free' here
  163 |                                         free(buffer);
      |                                         ^~~~~~~~~~~~

Comment 6 Jonathan Wakely 2023-02-02 12:21:04 UTC
Fixes available upstream:
https://github.com/vgropp/bwm-ng/pull/37
https://github.com/vgropp/bwm-ng/pull/42

Comment 7 Jonathan Wakely 2023-02-02 12:28:14 UTC
https://github.com/vgropp/bwm-ng/pull/25 is also needed, but I've fixed that on rawhide.

The simplest solution is probably to just update to the upstream 0.6.3 release.

Comment 8 Fedora Update System 2023-02-25 09:11:00 UTC
FEDORA-2023-5a90f912e9 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5a90f912e9

Comment 9 Fedora Update System 2023-02-25 09:13:52 UTC
FEDORA-2023-6dcad23d31 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-6dcad23d31

Comment 10 Fedora Update System 2023-02-26 02:02:01 UTC
FEDORA-2023-5a90f912e9 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-5a90f912e9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2023-02-26 02:02:51 UTC
FEDORA-2023-6dcad23d31 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-6dcad23d31`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-6dcad23d31

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2023-03-06 02:14:25 UTC
FEDORA-2023-6dcad23d31 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2023-03-11 03:09:26 UTC
FEDORA-2023-5a90f912e9 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.