Bug 2113926

Created attachment 1902833 [details]
hypershift deployment hang

Description of problem:
-----------------------------------------
hypershift cluster deployment hang due to nil pointer dereference for hostedControlPlane.Spec.Etcd.Managed

when looking into the control plan logs, we see the above error:

{"level":"info","ts":"2022-08-02T09:24:30Z","msg":"Reconciling etcd cluster status for managed strategy","controller":"hostedcontrolplane","controllerGroup":"hypershift.openshift.io","controllerKind":"HostedControlPlane","hostedControlPlane":{"name":"hypercluster","namespace":"hypercluster-hypercluster"},"namespace":"hypercluster-hypercluster","name":"hypercluster","reconcileID":"1ff13b29-1a7e-48fa-8269-c13c63e7a7f3"}
{"level":"info","ts":"2022-08-02T09:24:30Z","msg":"Observed a panic in reconciler: runtime error: invalid memory address or nil pointer


and by looking into the hpc spec:

Spec:
  Autoscaling:
  Cluster ID:                      76e4928a-e9a4-41b4-b713-1c2e5a4e17fc
  Controller Availability Policy:  SingleReplica
  Dns:
    Base Domain:  qe.lab.redhat.com
  Etcd:
    Management Type:                   Managed
  Fips:                                false
  Infra ID:                            hypercluster
  Infrastructure Availability Policy:  SingleReplica
  Issuer URL:                          https://kubernetes.default.svc
  Machine CIDR:                        192.168.128.0/24
  Network Type:                        OVNKubernetes
  Olm Catalog Placement:               management
  Platform:
    Agent:
      Agent Namespace:  infraenv-0
    Type:               None
  Pod CIDR:             10.132.0.0/14
  Pull Secret:
    Name:         pull-secret
  Release Image:  quay.io/openshift-release-dev/ocp-release:4.11.0-rc.6-x86_64
  Service CIDR:   172.31.0.0/16
  Services:
    Service:  APIServer
    Service Publishing Strategy:
      Type:   LoadBalancer
    Service:  OAuthServer
    Service Publishing Strategy:
      Type:   Route
    Service:  OIDC
    Service Publishing Strategy:
      Type:   Route
    Service:  Konnectivity
    Service Publishing Strategy:
      Type:   Route
    Service:  Ignition
    Service Publishing Strategy:
      Type:  Route
  Ssh Key:
    Name:  ssh-key


Version-Release number of selected component (if applicable):
-----------------------------------------

$ oc get clusterversion

NAME      VERSION       AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.11.0-rc.6   True        False         13h     Cluster version is 4.11.0-rc.6

How reproducible:
-----------------------------------------
100%


Steps to Reproduce:
-----------------------------------------
1. From the OCP UI console, install mce operator and hypershift operator 
2. Create infraenv with 3 hosts
3. Start the hypershift cluster creation

Actual results:
-----------------------------------------

hypershift cluster deployment hang due to nil pointer dereference for hostedControlPlane.Spec.Etcd.Managed



Expected results:
-----------------------------------------

hypershift deployment finished successfully 



Additional info:
-----------------------------------------