Bug 2113954

Summary: Ignition override v3.2.0 renders as v3.1 in day2 flow
Product: Red Hat Advanced Cluster Management for Kubernetes Reporter: Mat Kowalski <mko>
Component: Infrastructure OperatorAssignee: Mat Kowalski <mko>
Status: VERIFIED --- QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rhacm-2.7CC: ccrum, dcain, oourfali, skoksal, trwest, yfirst
Target Milestone: ---   
Target Release: rhacm-2.7   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2099929, 2115145    

Description Mat Kowalski 2022-08-02 12:26:08 UTC 
*Description of the problem:*

 It has been observed that the ignition override like

{code}
{"ignition": \{"version": "3.2.0"}, "storage": \{"disks":[{"device":"/dev/sdb","partitions":[{"label":"root","number":4,"resize":true,"sizeMiB":204800}],"wipeTable":false}],"files": [\{"path": "/tmp/example", "contents": {"source": "data:text/plain;base64,aGVscGltdHJhcHBlZGluYXN3YWdnZXJzcGVj"}}]}}
{code}

results in a rendered day2 worker ignition as

{code}
{"ignition":\{"config":{"merge":[{"source":"http://10.50.0.98:22624/config/worker","verification":{}}],"replace":\{"verification":{}}},"proxy":{},"security":\{"tls":{"certificateAuthorities":[{"source":"data:text/plain;charset=utf-8;base64,LS0[...]URS0tLS0tCg==","verification":{}}]}},"timeouts":{},"version":"3.1.0"},"passwd":{},"storage":\{"disks":[{"device":"/dev/sdb","partitions":[{"label":"root","number":4,"sizeMiB":204800},\{"label":"lso_20G_1","sizeMiB":20000},\{"label":"lso_20G_2","sizeMiB":20000},\{"label":"lso_20G_3","sizeMiB":20000}],"wipeTable":false}],"files":[\{"group":{},"overwrite":true,"path":"/etc/hostname","user":\{"name":"root"},"contents":\{"source":"data:,cu2","verification":{}},"mode":420}]},"systemd":{}}
{code}

Please note explicit v3.2.0 in the override and v3.1.0 in the rendered file.

*How reproducible:*

 CI job `edge-e2e-ai-operator-ztp-sno-day2-workers-ignitionoverride` is now a stable reproducer of the issue. The job uses the following ignition

{code}
BAREMETALHOSTS_IGNITION_OVERRIDE='\{"ignition":{"version":"3.2.0"},"storage":\{"disks":[{"device":"/dev/sda","partitions":[{"label":"root","number":4,"resize":true,"sizeMiB":61440},\{"label":"lso_1G_1","sizeMiB":1024},\{"label":"lso_1G_2","sizeMiB":1024},\{"label":"lso_1G_3","sizeMiB":1024}],"wipeTable":false}]}}'
{code}

and results in the ignition v3.1.0 with missing `resize: true`.

*When introduced:*

https://issues.redhat.com/browse/MGMT-9064

*Related issues:*

https://bugzilla.redhat.com/show_bug.cgi?id=2099929
https://issues.redhat.com/browse/MGMTBUGSM-447
Comment 1 Chad Crum 2023-02-01 21:28:20 UTC 
This was verified in https://issues.redhat.com/browse/MGMTBUGSM-447. resize=true showed up in our testing along with correct ignition.