Bug 2115999

Summary: Package 'filesystem' has (currently) unsupported <lua> script in '%posttrans'
Product: [Fedora] Fedora Reporter: Jeffrey Serio <serio.jeffrey>
Component: rpm-ostreeAssignee: Jonathan Lebon <jlebon>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 36CC: dustymabe, jlebon, jmarrero, jonathan, lucab, miabbott, mosvald, mpitt, ovasik, pavel, philip.wyett, pknirsch, robertthomasfairley, serio.jeffrey, travier, walters, walters
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: rpm-ostree-2022.12-4.fc36 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-08-10 01:16:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jeffrey Serio 2022-08-06 00:39:04 UTC
Description of problem: Building of ostree commit fails with the above error.


Version-Release number of selected component (if applicable): filesystem-3.18-1.fc36


How reproducible: Not sure


Steps to Reproduce:
1. Run rpm-ostree compose tree --unified-core --cachedir=$CACHEDIR --repo=$BUILD_REPO $OSTREE_FILE
2. Observe that Running post scripts step fails for filesystem package.

Actual results:
"error: Package 'filesystem' has (currently) unsupported <lua> script in '%posttrans'"

Expected results:
The rpm-ostree compose tree command succeeds

Additional info:
This only appears relevant to rpm-ostree. The same package succeeds when upgrading on regular DNF-based Fedora. It might be related to the change here: https://src.fedoraproject.org/rpms/filesystem/c/47d37ac94192f792df5ed0faa15e78daa6644758?branch=36

Comment 1 Martin Pitt 2022-08-06 08:31:54 UTC
I get that in my project as well, it started to fail within the last week: https://github.com/martinpitt/ostree-pitti-workstation/runs/7701806376?check_suite_focus=true

Running posttrans scripts...done
error: Package 'filesystem' has (currently) unsupported <lua> script in '%posttrans'
e at lower priority 100 with module at priority 200.

CC'ing Colin, in case this should be reassigned to rpm-ostree.

Comment 2 Martin Osvald 🛹 2022-08-08 06:17:19 UTC
Thank you for reporting this issue.

The mentioned commit in comment 0:

https://src.fedoraproject.org/rpms/filesystem/blob/47d37ac94192f792df5ed0faa15e78daa6644758/f/filesystem.spec#_170

introduced a new %posttrans lua script to remove dependency on /bin/sh (almost identical code is in `setup` package but in %post).

It looks that rpm-ostree can cope with lua in %pretrans and %post, but doesn't support it in %posttrans yet.

I don't know the full history of the current situation yet, but can notice a debate about it here:

https://github.com/coreos/rpm-ostree/issues/749

Comment 3 Martin Pitt 2022-08-08 07:06:41 UTC
Thanks Martin! This indeed breaks CoreOS builds really hard right now. I asked for a workaround in https://github.com/coreos/rpm-ostree/issues/749. Fixing this properly seems to be a difficult problem, but we can't stop CoreOS builds for the next few years..

Comment 4 Martin Osvald 🛹 2022-08-08 07:13:38 UTC
(In reply to Martin Pitt from comment #3)
> Thanks Martin! This indeed breaks CoreOS builds really hard right now. I
> asked for a workaround in https://github.com/coreos/rpm-ostree/issues/749.
> Fixing this properly seems to be a difficult problem, but we can't stop
> CoreOS builds for the next few years..

Of course, I will fix it today either by reverting the change or moving the lua block to %post.

I definitely didn't and don't want to disrupt CoreOS.

Comment 5 Martin Osvald 🛹 2022-08-08 07:58:29 UTC
Can see (thanks Luca!):

https://github.com/coreos/rpm-ostree/issues/749#issuecomment-1207756971

That this problem got fixed/worked around by:

https://github.com/coreos/rpm-ostree/pull/3909

with the fix in Rawhide already:

https://src.fedoraproject.org/rpms/rpm-ostree/c/0e40231a60f2bee7cff77e55445a47fb3b9f83bd?branch=rawhide

So switching to rpm-ostree to backport it to f36 and if possible also to f35.

Comment 6 Fedora Update System 2022-08-08 15:25:08 UTC
FEDORA-2022-5e830ab868 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-5e830ab868

Comment 7 Fedora Update System 2022-08-09 02:52:33 UTC
FEDORA-2022-5e830ab868 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-5e830ab868`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-5e830ab868

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2022-08-10 01:16:41 UTC
FEDORA-2022-5e830ab868 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.