Bug 2116066
| Summary: | Review Request: rust-primal-estimate - Estimation of upper and lower bounds for π(n) and p_k | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | rust-primal-estimate-0.3.2-1.fc38 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-09-03 03:02:55 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2116081, 2116083 | ||
|
Description
Orion Poplawski
2022-08-06 19:45:55 UTC
Please open an issue with upstream to remind them that redistributed code (i.e. also the crates they individually publish and redistribute via crates.io) need to contain license files for MIT and Apache-2.0 licenses. For reference, I've opened dozens of similar issues for other crates, like here: https://github.com/danieldg/ordered-stream/issues/1 I've filed https://github.com/huonw/primal/issues/42 Upstream now provides the license files. Spec URL: https://orion.fedorapeople.org/rust-primal-estimate.spec SRPM URL: https://orion.fedorapeople.org/rust-primal-estimate-0.3.2-1.fc38.src.rpm Looks like you didn't regenerate the spec file with rust2rpm for 0.3.2?
> # Upstream license specification: MIT/Apache-2.0
This line is no longer generated, it looks like upstream changed this to "MIT OR Apache-2.0" with v0.3.2.
Another (small) issue is the overly long Summary tag. Please shorten it so sensible length, something like
Summary: Estimation of the number of primes below n and the k-th prime
instead of
Summary: State-of-the-art estimation of upper and lower bounds for π(n) (the number of primes below n) and p_k (the k-th prime)
The summary shouldn't be longer than ~70 characters.
Other than that, the package looks good, and I'll approve it once those two are cleaned up.
PS: Please make sure you don't "fedpkg import" the SRPM file that you uploaded, but either copy the files manually into the new dist-git repo, or rebuild the SRPM with "rpmbuild -bs" first (which doesn't mangle rpmautospec macros).
Okay, I believe I've fixed those issues. Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide x test suite is run and all unit tests pass (tests are disabled to break a dependency loop) - latest version of the crate is packaged - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches === Looks good to me now (you might want to update the bug title to match the new summary in the .spec file). You'll need to re-disable the tests before importing the package to Fedora, this modification seems to have been lost when you re-ran rust2rpm. Just as an FYI, for Rust crates which have disabled test suites to break circular dependencies, we usually just leave the tests disabled permanently. Doing bootstrap builds is usually not worth it. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-primal-estimate Checked in and built. |