Bug 211703

Summary: Review Request: nyquist - Sound synthesis and composition language with a Lisp syntax
Product: [Fedora] Fedora Reporter: Gérard Milmeister <gemi>
Component: Package ReviewAssignee: Mamoru TASAKA <mtasaka>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-11-04 12:06:10 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163779    

Description Gérard Milmeister 2006-10-20 21:55:38 UTC 
Spec URL: http://math.ifi.unizh.ch/fedora/spec/nyquist.spec
SRPM URL: http://math.ifi.unizh.ch/fedora/5/i386/SRPMS.gemi/nyquist-2.31-2.src.rpm
Description:
Nyquist is a language for sound synthesis and music
composition. Unlike score languages that tend to deal only with
events, or signal processing languages that tend to deal only with
signals and synthesis, Nyquist handles both in a single integrated
system. Nyquist is also flexible and easy to use because it is based
on an interactive Lisp interpreter.
Comment 1 Mamoru TASAKA 2006-10-21 11:27:50 UTC 
I will review this later.
Comment 2 Mamoru TASAKA 2006-10-21 14:26:22 UTC 
Well, I quite don't know how to use this,
however there seems nothing to be fixed (I will recheck).

-------------------------------------------------------------------------
Just a interest.
In the build log, I see:

portaudio/pa_linux_alsa/pa_linux_alsa.c: In function 'Wait':
portaudio/pa_linux_alsa/pa_linux_alsa.c:2251: warning: comparisons like X<=Y<=Z
do not have their mathematical meaning

And portaudio/pa_linux_alsa/pa_linux_alsa.c says:

  2249      }
  2250      
  2251      assert( !(captureAvail == playbackAvail == INT_MAX) );
  2252  
  2253      commonAvail = MIN( captureAvail, playbackAvail );
  2254      commonAvail -= commonAvail % stream->frames_per_period;

Perhaps the line 2251 is a bug.
Comment 3 Mamoru TASAKA 2006-10-25 08:11:21 UTC 
ping?
Comment 4 Gérard Milmeister 2006-10-25 19:43:27 UTC 
Hmm, this is strange. It does not make much sense. Probably it should be
!(captureAvail == INT_MAX && playbackAvail == INT_MAX)
Comment 5 Mamoru TASAKA 2006-10-31 14:43:06 UTC 
Ping?

(In reply to comment #4)
> Hmm, this is strange. It does not make much sense. Probably it should be
> !(captureAvail == INT_MAX && playbackAvail == INT_MAX)

I have not yet looked into this package, however would you upload
new srpm and spec with this source fixed?
Comment 6 Gérard Milmeister 2006-11-02 21:32:32 UTC 
Here is the package which includes the fix (spec at the same place):
http://math.ifi.unizh.ch/fedora/6/i386/SRPMS.gemi/nyquist-2.31-3.src.rpm
Comment 7 Gérard Milmeister 2006-11-02 22:52:55 UTC 
Oops, it should be:
http://math.ifi.unizh.ch/fedora/6/i386/SRPMS.gemi/nyquist-2.31-3.fc6.src.rpm
Comment 8 Mamoru TASAKA 2006-11-03 07:50:49 UTC 
Okay, this package meets the demand by
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

-------------------------------------------------------------------------------
This package (nyquist) is APPROVED by me.
Comment 9 Gérard Milmeister 2006-11-04 12:06:10 UTC 
Built on FC5, FC6 and FC7.
Added entries to owners and comps files.
Thanks for the review.