Bug 2117232

The buildrequires you have added are totally insane, this package doesn't need perl* or python-devel to compile.

BuildRequires:  perl(Test::More::UTF8)
BuildRequires:  perl(Test::WWW::Mechanize)
BuildRequires:  perl-rpm-build-perl
BuildRequires:  perl-podlators
BuildRequires:  python3-devel
BuildRequires:  python3dist(iso8601)
BuildRequires:  python3dist(setuptools)
BuildRequires:  python3dist(pytest)
BuildRequires:  python3dist(urllib3)
BuildRequires:  python3dist(wheel)



Try using these only.

BuildRequires:  python3
BuildRequires:  python3-rpm-macros
BuildRequires:  python3-iso8601
BuildRequires:  python3-pytest
BuildRequires:  python3-setuptools

Thanks for the hint !

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-m3u8.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-m3u8-3.1.0-2.fc36.src.rpm

%changelog
* Mon Aug 08 2022 Martin Gansser <martinkg> 3.1.0-2
- Delete superfluous dependencies

Update

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-m3u8.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-m3u8-3.3.0-1.fc37.src.rpm

%changelog
* Mon Aug 08 2022 Martin Gansser <martinkg> 3.3.0-1
- Update to 3.3.0

Update to 3.4.0

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-m3u8.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-m3u8-3.4.0-1.fc37.src.rpm

%changelog
* Fri Mar 03 2023 Martin Gansser <martinkg> 3.4.0-1
- Update to 3.4.0

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5589713
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2117232-python-m3u8/fedora-rawhide-x86_64/05589713-python-m3u8/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

There is a line existed in %prep of SPEC file:
sed -i -e 's|3.2.0|3.3.0|' setup.py
why does it exist?

2. I suggest change %{python3_sitelib}/%{srcname}-%{version}-py?.??.egg-info to %{python3_sitelib}/%{srcname}-%{version}-py%{python3_version}.egg-info 
3. There is a naming rule about python library, which add a subpackage using the python3- prefix. ref: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/#_naming

(In reply to Felix Wang from comment #6)
> There is a line existed in %prep of SPEC file:
> sed -i -e 's|3.2.0|3.3.0|' setup.py
> why does it exist?

The developer forgot to change the version in the setup.py file when updating to version 3.3.0 and I forgot to remove it when updating again.

(In reply to Felix Wang from comment #7)
> 2. I suggest change %{python3_sitelib}/%{srcname}-%{version}-py?.??.egg-info
> to %{python3_sitelib}/%{srcname}-%{version}-py%{python3_version}.egg-info 
> 3. There is a naming rule about python library, which add a subpackage using
> the python3- prefix. ref:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/
> #_naming

fix package:

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-m3u8.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-m3u8-3.4.0-2.fc37.src.rpm

%changelog
* Sun Mar 05 2023 Martin Gansser <martinkg> 3.4.0-2
- remove version fix in setup.py
- use python3 version naming for info file
- use naming rule for python library

Sorry for the latest response, I am busy with many other stuff.

> %description
> Summary:        %{summary}

> %description -n python3-%{srcname}
> Summary:        %{summary}

The Summary tag was included in description, it should be removed.

> %global _unpackaged_files_terminate_build 1

Without this line, it can also build successfully. Any ideas with this line?

fix package:

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-m3u8.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-m3u8-3.4.0-3.fc38.src.rpm

%changelog
* Wed Mar 29 2023 Martin Gansser <martinkg> 3.4.0-3
- Cleanup specfile

Created attachment 1954362 [details]
The .spec file difference from Copr build 5589713 to 5725941

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5725941
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2117232-python-m3u8/fedora-rawhide-x86_64/05725941-python-m3u8/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

After looking at the .spec file and review.txt, I approved the package.

@Felix Wang
Thanks for reviewing the request.

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-m3u8