Bug 211772

Summary:	gitk doesn't respect $GIT_OBJECT_DIRECTORY
Product:	[Fedora] Fedora	Reporter:	Frank Ch. Eigler <fche>
Component:	git	Assignee:	Chris Wright <chrisw>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5	CC:	extras-qa
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	git-1_5_0_2-1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-03-19 23:29:18 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Frank Ch. Eigler 2006-10-22 15:47:35 UTC

Description of problem:
gitk dies if GIT_OBJECT_DIRECTORY being set means .git/objects is replaced
by a directory elsewhere

Version-Release number of selected component (if applicable):
gitk-1.4.2.4-1.fc5

How reproducible:
always

Steps to Reproduce:
1. set GIT_OBJECT_DIRECTORY
2. check out some git repo
3. observer that .git/objects does not exist
4. run gitk in same directory
  
Actual results:
gitk crashes

Expected results:
gitk should run

Additional info:
Putting a symlink .git/objects -> $GIT_OBJECT_DIRECTORY kludges around this

Comment 1 Frank Ch. Eigler 2006-11-28 04:50:54 UTC

According to an strace, this appears to come from git ls-remote => git-peek-remote

Comment 2 Chris Wright 2007-03-19 23:29:18 UTC

This works fine for me.  peek-remote has been properly using setup_git_directory
since version git version 1.0 AFAICT.  And current gitk no longer use ls-remote,
but instead uses show-ref (since 1.5.0.x).  I'm closing this as CURRENTRELASE,
starting with 1.5.0.2.  Please reopen if this is still a problem.