Bug 2118055

Summary:	When installing errata via katello-agent, content_action_finish_timeout is ignored and tasks don't wait for client status to finish
Product:	Red Hat Satellite	Reporter:	Joniel Pasqualetto <jpasqual>
Component:	Errata Management	Assignee:	satellite6-bugs <satellite6-bugs>
Status:	CLOSED ERRATA	QA Contact:	addubey
Severity:	high	Docs Contact:
Priority:	high
Version:	6.10.7	CC:	ahumbe, aruzicka, damoore, gtalreja, pcreech, sajha, saydas
Target Milestone:	6.12.0	Keywords:	PrioBumpGSS, Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	tfm-rubygem-katello-4.5.0.12-1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-11-16 13:35:16 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Joniel Pasqualetto 2022-08-13 20:18:11 UTC

Description of problem:

When installing errata via katello-agent, task ends with success for any task that is fetched by gofer and don't end within content_action_accept_timeout.

So, for example a task to install errata on a host will start and if it doesn't fail in  20 seconds (default value for content_action_accept_timeout), the task will end with success. If the task fails on the client side after 20 seconds, satellite would not know.

Version-Release number of selected component (if applicable):

Satellite 6.10.7
Probably also affects 6.11, but didn't test it. 

Steps to Reproduce:

1. Setup a Satellite 6.10 having katello-agent capabilities

2. Start an errata installation task which will take more than 20 seconds to finish (or modify the content_action_accept_timeout to a lower value).

3. Observe that in 20 seconds, while the task is still running on the client, on Satellite it will be already finished with success.

Extra test: start a task that will take more than 20 seconds to FAIL. In 20 seconds, the task on satellite will be marked as success independently of what really happened to it on the client.

Extra info: if the task fails, on the host, in less than 20 seconds then Satellite will get the correct status.

Actual results:

Tasks end with success in 20 seconds (only condition for success is the host to get the task from its queue) independently of the actual result on the host.

Expected results:

Task should wait content_action_finish_timeout for the host to send the actual output of the task.

Additional info:

Comment 2 Adam Ruzicka 2022-08-22 10:27:47 UTC

This is not a generic tasks-as-the-engine issue, moving over to errata.

Comment 8 errata-xmlrpc 2022-11-16 13:35:16 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.12 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:8506