Bug 2118090

Summary:	Review Request: rust-signature_derive - Custom derive support for the 'signature' crate
Product:	[Fedora] Fedora	Reporter:	Stuart D Gathman <stuart>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-10-14 02:24:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2117954

Description Stuart D Gathman 2022-08-14 03:12:06 UTC

Spec URL: https://gathman.org/linux/SPECS/rust-signature_derive.spec
SRPM URL: https://gathman.org/linux/f37/src/rust-signature_derive-1.0.0~pre.4-1.fc37.src.rpm
Description: Support customized derive
Fedora Account System Username:sdgathman

Comment 1 Fabio Valentini 2022-08-17 10:28:25 UTC

I wonder why this says "Generated by rust2rpm 21"? You should be running rust2rpm v22 by now, as it's stable on all current Fedora branches.
Regenerating with rust2rpm v22 defaults to SPDX license identifiers, among other changes. Other than this confusing bit, package looks good to me.

Comment 2 Fabio Valentini 2022-10-11 09:19:29 UTC

*two-months-later-ping*

Please address the issue I mentioned in my last comment.
Once that is resolved, the package is very likely to pass review without problems.

Just ensure that the version you're submitting here matches what is required by "rust-signature".
Dependencies for pre-releases are very strict, so make sure to package the correct one.

Comment 3 Stuart D Gathman 2022-10-12 23:54:36 UTC

Spec URL: https://gathman.org/linux/SPECS/rust-signature_derive.spec
SRPM URL: https://gathman.org/linux/f37/src/rust-signature_derive-1.0.0~pre.7-1.fc37.src.rpm

Comment 4 Fabio Valentini 2022-10-13 09:54:00 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (Apache-2.0 OR MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

Please ensure that you don't import the SRPM file that is already mangled by rpmautospec, but either rebuild a "pristine" one with "rpmbuild -bs", or copy files into the new dist-git repo manually.

Comment 5 Gwyn Ciesla 2022-10-13 17:37:18 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-signature_derive