Bug 2118592

Summary:	Add (at least) recommends on libatomic and switch to requires for compiler-rt?
Product:	[Fedora] Fedora	Reporter:	Terje Røsten <terje.rosten>
Component:	clang	Assignee:	Tom Stellard <tstellar>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	36	CC:	airlied, jchecahi, kkleine, npopov, sbergman, sguelton, siddharth.kde, tstellar
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	clang-14.0.5-7.fc38	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-08-29 20:53:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Terje Røsten 2022-08-16 08:23:07 UTC

Description of problem:

Reading 

https://clang.llvm.org/docs/Toolchain.html

it seems libatomic is required when libgcc_s is used (which is the case for Fedora), hence it make sense to at least add an 

Recommends: libatomic

it could be argued to be an Requires: too I think.

Ditto for compiler-rt, to build with clang and flags: 

-fsanitize=undefined | -fsanitize=address

compiler-rt is required, changing from Recommends to Required for compiler-rt seems sensible to me.

Comment 1 Tom Stellard 2022-08-16 16:25:31 UTC

I think making libatomic a Recommends makes sense.  I'm undecided about making compiler-rt a Requires.  You don't need compiler-rt for normal use of the compiler, so it seems to to fit well as a Recommends.

The main reason to use Recommends instead of Requires is that it helps keep the install footprint of llvm smaller for container images.

Comment 2 Terje Røsten 2022-08-16 20:55:03 UTC

Ok, sounds good.

Comment 3 serge_sans_paille 2022-08-29 09:12:19 UTC

Some bikeshedding here: compiler-rt can be compiled to provide atomic support (through a static or shared library). Should we try to activate that?

Comment 4 serge_sans_paille 2022-08-29 09:21:49 UTC

See https://src.fedoraproject.org/rpms/clang/pull-request/178

Comment 5 Fedora Update System 2022-08-29 19:59:51 UTC

FEDORA-2022-a682504360 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a682504360

Comment 6 Fedora Update System 2022-08-29 20:53:49 UTC

FEDORA-2022-a682504360 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 serge_sans_paille 2022-08-30 06:11:56 UTC

Fixed by clang-14.0.5-7.fc38