Bug 2118997

Summary: Update virt-what to 1.25 in RHEL 9.1
Product: Red Hat Enterprise Linux 9 Reporter: YongkuiGuo <yoguo>
Component: virt-whatAssignee: Richard W.M. Jones <rjones>
Status: CLOSED ERRATA QA Contact: YongkuiGuo <yoguo>
Severity: medium Docs Contact:
Priority: low    
Version: 9.1CC: bstinson, jwboyer, kkiwi, minl, mrezanin, qzhang, rjones, smokris, virt-maint, wshi, ymao, yoguo
Target Milestone: rcKeywords: Triaged
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: virt-what-1.25-1.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 2118195 Environment:
Last Closed: 2022-11-15 11:12:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2118195    
Bug Blocks:    

Description YongkuiGuo 2022-08-17 09:44:54 UTC
+++ This bug was initially created as a clone of Bug #2118195 +++

Currently, CentOS Stream 8 includes virt-what-1.18 with patches up to 1.22. This version outputs nothing when run inside Illumos/SmartOS LX, so virtual machines are incorrectly identified as bare metal.

virt-what 1.24 includes a patch (https://listman.redhat.com/archives/virt-tools-list/2022-May/017568.html) to support detecting Illumos/SmartOS LX. Could you update the CentOS Stream 8 package to include that patch (or point me to instructions on how to contribute that package update)?

--- Additional comment from Klaus Heinrich Kiwi on 2022-08-16 12:37:51 UTC ---

Not assigning to anyone yet, but maybe Miroslav could give us some pointers here?

--- Additional comment from Richard W.M. Jones on 2022-08-16 13:28:12 UTC ---

We could do this for RHEL 8.7 but it's extremely tight, particularly
for QE to do any testing.  Yongkui what do you think?

Otherwise we'd move it to early in RHEL 8.8 cycle, but that would be
in a few months.

--- Additional comment from YongkuiGuo on 2022-08-17 02:10:56 UTC ---

(In reply to Richard W.M. Jones from comment #2)
> We could do this for RHEL 8.7 but it's extremely tight, particularly
> for QE to do any testing.  Yongkui what do you think?
> 
> Otherwise we'd move it to early in RHEL 8.8 cycle, but that would be
> in a few months.

Hi,rjones 

It's ok from the QE side. In that case, the virt-what version (1.24) in RHEL8.7 will be higher than in RHEL9.1.

--- Additional comment from Richard W.M. Jones on 2022-08-17 09:33:22 UTC ---

(In reply to YongkuiGuo from comment #3)
> It's ok from the QE side. In that case, the virt-what version (1.24) in
> RHEL8.7 will be higher than in RHEL9.1.

That will break the upgrade path (LEAPP) so we can't actually do that,
unless we also upgrade virt-what in RHEL 9.1.  We don't have a bug for
that (but bug 2114997 is the latest there).

Comment 4 YongkuiGuo 2022-08-18 08:27:12 UTC
The gating tests passed on AWS(x86_64 and aarch64), ESXi, Hyper-V, KVM, nested KVM and TCG (https://dashboard.osci.redhat.com/#/artifact/brew-build/aid/47185475).

Comment 5 YongkuiGuo 2022-08-18 09:30:33 UTC
Test passed on GCE x86_64 env:

[root@wshi-yoguo-x64 ~]# cat /etc/redhat-release 
Red Hat Enterprise Linux release 9.1 Beta (Plow)
[root@wshi-yoguo-x64 ~]# rpm -q virt-what
virt-what-1.25-1.el9.x86_64
[root@wshi-yoguo-x64 ~]# virt-what
google_cloud
kvm

------------------------------

Test passed on GCE aarch64 env:

[root@wshi-yoguo-aarch64 ~]# cat /etc/redhat-release 
Red Hat Enterprise Linux release 9.1 Beta (Plow)
[root@wshi-yoguo-aarch64 ~]# rpm -q virt-what
virt-what-1.25-1.el9.aarch64
[root@wshi-yoguo-aarch64 ~]# virt-what
google_cloud
kvm

Comment 6 minl 2022-08-18 10:19:56 UTC
Test passed on Nutanix VM:

[root@minl-9 ~]# cat /etc/redhat-release 
Red Hat Enterprise Linux release 9.1 Beta (Plow)
[root@minl-9 ~]# rpm -q virt-what
virt-what-1.25-1.el9.x86_64
[root@minl-9 ~]# virt-what --version
1.25
[root@minl-9 ~]# virt-what
nutanix_ahv
redhat
kvm

Comment 9 YongkuiGuo 2022-08-22 02:19:56 UTC
Verified this bug according to the above test results.

Comment 11 errata-xmlrpc 2022-11-15 11:12:59 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (virt-what bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:8282