Bug 211909

Summary: Paravirt console doesn't get setup if creating a domain with pygrub
Product: Red Hat Enterprise Linux 5 Reporter: Daniel Berrangé <berrange>
Component: libvirtAssignee: Daniel Veillard <veillard>
Status: CLOSED NOTABUG QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 5.0CC: xen-maint
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-03-09 16:48:57 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 211928    
Bug Blocks:    
Attachments:
Description Flags
Pass along VNC settings, even when using bootloader none

Description Daniel Berrangé 2006-10-23 19:53:52 UTC 
Description of problem:
If creating a domain using libvirt (eg, virsh create foo.xml), and the config
file is set to use pygrub for boot, the VNC paravirt console does not get
activated. If creating the same domain with an explicitly specified kernel &
initrd instead of pygrub, VNC works as expected

Version-Release number of selected component (if applicable):
libvirt-0.1.7

How reproducible:
ALWAYS

Steps to Reproduce:
1. Identify a domain 'somedomain' running with pygrub & VNC
2. Run 'virsh dumpxml somedomain > somedomain.xml'
3. Run 'virsh destroy somedomain'
4. Edit 'somdomain.xml' and remove the <os>...</os> block from the XML
5. Run  'virsh create somedomain.xml'  

Actual results:
No VNC console is setup

Expected results:
Paravirt VNC console is setup

Additional info:
The problem is actually partly in xend. The XenD sexpr for VNC has the '(vnc 1)'
within the '(image (linux ...))' SEXPR block. When using PyGrub though, there is
no '(image (liunux...))' block, so there is nowhere for libvirt to put the "(vnc
1)' bit required to activate the paravirt framebuffer.

XenD needs to be fixed to always check for a  (image (linux (vnc 1))) block,
even if using pygrub, and then libvirt can be fixed to  pass along VNC info all
the time.
Comment 1 Daniel Berrangé 2006-10-24 20:03:57 UTC 
Created attachment 139265 [details]
Pass along VNC settings, even when using bootloader

The attached patch makes libvirt pass in VNC settings in a (image) block, even
when using a bootloader. Needs a corresponding patch to XenD to work correctly.
Comment 2 RHEL Program Management 2006-10-26 19:02:23 UTC 
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux major release.  Product Management has requested further
review of this request by Red Hat Engineering, for potential inclusion in a Red
Hat Enterprise Linux Major release.  This request is not yet committed for
inclusion.
Comment 3 Jay Turner 2006-12-07 03:43:34 UTC 
QE ack for RHEL5.
Comment 6 Daniel Berrangé 2007-03-09 16:48:57 UTC 
The new generation paravirt framebuffer patches included in recent RHEL-5 xen
packages completely changed the config file format. As such the problem
described in this bug no longer exists.