Bug 2119303

Summary:	installer sometimes loads modules from /etc/puppetlabs, breaking execution
Product:	Red Hat Satellite	Reporter:	Evgeni Golov <egolov>
Component:	Installation	Assignee:	Ewoud Kohl van Wijngaarden <ekohlvan>
Status:	CLOSED MIGRATED	QA Contact:	Satellite QE Team <sat-qe-bz-list>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.11.0	CC:	ehelms, ekohlvan, saydas
Target Milestone:	Unspecified	Keywords:	MigratedToJIRA, Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-06-06 12:26:02 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Evgeni Golov 2022-08-18 08:58:34 UTC

Description of problem:
For reasons unknown to me, a user had a broken puppet-lvm module in /etc/puppetlabs/code/modules/puppetlabs-lvm/, which resulted in the following error when Puppet tried to load it:
Error: Could not run: cannot load such file -- puppet_x/lvm/output

Such a local issue should not have an effect on the execution of the Installer (as it should not load random modules from /etc/puppetlabs, those could be incompatible with the contents of the installer).

Kafo, when running Puppet, does generate a custom configuration to avoid this problem:
# cat /tmp/kafo_installation20220818-28102-108x1gp/puppet.conf
[main]
basemodulepath = /usr/share/foreman-installer/modules:/usr/share/gems/gems/kafo-6.4.0/lib/kafo/../..//modules
color = false
environmentpath = /tmp/kafo_installation20220818-28102-108x1gp/environments
evaltrace = true
factpath = /tmp/kafo_installation20220818-28102-108x1gp/facts
hiera_config = /usr/share/foreman-installer/config/foreman-hiera.yaml
noop = false
profile = false
reports = 
show_diff = true

However, we also have a `apply_puppet_code` function in our hooks (https://github.com/theforeman/foreman-installer/blob/43067e91db3439d662adad313ac43853b4cf0992/hooks/boot/01-kafo-hook-extensions.rb#L34-L37) which does _NOT_ pass a custom config and thus loads the global one from /etc, which DOES read the modules and explodes.

This results in the following error when the installer is executed:
2022-08-18 10:17:51 [ERROR ] [root] Failed to ensure rh-postgresql12-postgresql-server, rh-redis5-redis, foreman-selinux, katello-selinux, candlepin-selinux, pulpcore-selinux are installed
2022-08-18 10:17:51 [ERROR ] [root] Error: Could not run: cannot load such file -- puppet_x/lvm/output
Failed to ensure rh-postgresql12-postgresql-server, rh-redis5-redis, foreman-selinux, katello-selinux, candlepin-selinux, pulpcore-selinux are installed
Error: Could not run: cannot load such file -- puppet_x/lvm/output

Version-Release number of selected component (if applicable):
6.11

How reproducible:
100%

Steps to Reproduce:
1. break some auto-loaded code in /etc/puppetlabs/code
2. run installer

Actual results:
Installer fails

Expected results:
Installer succeeds

Additional info:

Comment 1 Bryan Kearney 2022-08-18 12:05:21 UTC

Upstream bug assigned to ekohlvan

Comment 2 Bryan Kearney 2022-08-18 12:05:23 UTC

Upstream bug assigned to ekohlvan

Comment 6 Brad Buckingham 2023-10-30 11:29:29 UTC

Bulk setting Target Milestone = 6.15.0 where sat-6.15.0+ is set.

Comment 8 Eric Helms 2024-06-06 12:26:02 UTC

This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there.

Due to differences in account names between systems, some fields were not replicated.  Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information.

To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "SAT-" followed by an integer.  You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like:

"Bugzilla Bug" = 1234567

In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information.