Bug 2119812
| Summary: | Review Request: ndpi - Open Source Deep Packet Inspection Software Toolkit | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alessio <alciregi> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | benson_muite, jonathan, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-08-22 12:42:39 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Alessio
2022-08-19 13:28:51 UTC
I've flagged your review request as needing a sponsor per https://docs.fedoraproject.org/en-US/package-maintainers/Package_Review_Process/#_contributor Disregard. Wrong BZ. Thanks for submitting this. Some observations on running fedora-review: - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: ndpi-devel. Does not provide -static: ndpi- devel. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#packaging-static-libraries May also wish to check licenses of some of the included external components. Thank you. New spec and srpm: Spec URL: https://alciregi.fedorapeople.org/ndpi/ndpi.spec SRPM URL: https://alciregi.fedorapeople.org/ndpi/ndpi-4.4-1.fc37.src.rpm (In reply to Benson Muite from comment #3) > May also wish to check licenses of some of the included external components. Mmm, in addition, looking at the scripts in /usr/libexec/ndpi/utils, they point to a directory supposing that they still resides in the sources dir. DEST=../src/lib/inc_generated/ I don't know how useful it is to include them. Maybe using sed to replace DEST= to /tmp and including them in the devel package. This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience. |