Bug 2119964

Summary: rubygem-irb does not pull rubygem-rdoc as dependency
Product: [Fedora] Fedora Reporter: Alex <aleksq>
Component: rubyAssignee: Jun Aruga <jaruga>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: 36CC: jaruga, jprokop, lutter, mastahnke, mo, mtasaka, pvalena, ruby-packagers-sig, s, strzibny, vanmeeuwen+fedora, vondruch
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: ruby-3.1.2-168.fc38 ruby-3.1.2-169.fc37 ruby-3.1.2-169.fc36 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-09-01 20:27:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Alex 2022-08-20 11:02:26 UTC
Description of problem:

Installing rubygem-irb directly does not pull rubygem-rdoc dependency which is required for irb to run (otherwise error occurs).


Version-Release number of selected component (if applicable):
Name         : rubygem-irb
Version      : 1.4.1
Release      : 164.fc36


How reproducible:


Steps to Reproduce:
1. sudo dnf install rubygem-irb
2. Make sure that rubygem-rdoc is not installed, otherwise "sudo dnf remove rubygem-rdoc"
3. Run irb from shell.

Actual results:

<internal:/usr/share/rubygems/rubygems/core_ext/kernel_require.rb>:85:in `require': cannot load such file -- rdoc (LoadError)
	from <internal:/usr/share/rubygems/rubygems/core_ext/kernel_require.rb>:85:in `require'
	from /usr/share/gems/gems/irb-1.4.1/lib/irb/input-method.rb:17:in `<top (required)>'
	from /usr/share/gems/gems/irb-1.4.1/lib/irb/context.rb:14:in `require_relative'
	from /usr/share/gems/gems/irb-1.4.1/lib/irb/context.rb:14:in `<top (required)>'
	from /usr/share/gems/gems/irb-1.4.1/lib/irb.rb:16:in `require_relative'
	from /usr/share/gems/gems/irb-1.4.1/lib/irb.rb:16:in `<top (required)>'
	from <internal:/usr/share/rubygems/rubygems/core_ext/kernel_require.rb>:85:in `require'
	from <internal:/usr/share/rubygems/rubygems/core_ext/kernel_require.rb>:85:in `require'
	from /usr/share/gems/gems/irb-1.4.1/exe/irb:9:in `<top (required)>'
	from /usr/bin/irb:25:in `load'
	from /usr/bin/irb:25:in `<main>'


Expected results:

irb (The Interactive Ruby) REPL starts with a prompt and without error.

Additional info:

Comment 1 Vít Ondruch 2022-08-23 08:45:38 UTC
Good catch. This dependency seems to be introduced by [1]. But it also appears that it should have been optional, but it is not. I have send PR with proposed fix upstream. Lets see what is their response.



[1]: https://github.com/ruby/irb/commit/026700499dfd640b2072d7bf0370247a98d5ac40

Comment 2 Vít Ondruch 2022-08-23 08:49:32 UTC
(In reply to Vít Ondruch from comment #1)
> Lets see what is their response.

I should probably elaborate that in current state, there would need to be `Require: rubygem(rdoc)` added for rubygem-irb. But if the patch is accepted upstream, it could be just `Recommends: rubygem(rdoc)`.

Comment 3 Jun Aruga 2022-08-24 15:49:36 UTC
> But if the patch is accepted upstream, it could be just `Recommends: rubygem(rdoc)`.

As the patch was accepted, and merged at <https://github.com/ruby/irb/pull/393
>, I think the `Recommends: rubygem(rdoc)` is the best solution on Fedora ruby. I am working on it.

Comment 4 Jun Aruga 2022-08-26 16:27:00 UTC
I sent the PR.
https://src.fedoraproject.org/rpms/ruby/pull-request/130

Comment 5 Fedora Update System 2022-09-01 20:23:21 UTC
FEDORA-2022-7b269a84e6 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-7b269a84e6

Comment 6 Fedora Update System 2022-09-01 20:27:31 UTC
FEDORA-2022-7b269a84e6 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2022-09-06 14:55:29 UTC
FEDORA-2022-53358fd5c8 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-53358fd5c8

Comment 8 Fedora Update System 2022-09-06 20:30:33 UTC
FEDORA-2022-53358fd5c8 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-53358fd5c8`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-53358fd5c8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2022-09-14 00:20:03 UTC
FEDORA-2022-53358fd5c8 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2022-09-15 22:07:22 UTC
FEDORA-2022-9f08ba013b has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-9f08ba013b

Comment 11 Fedora Update System 2022-09-16 02:41:32 UTC
FEDORA-2022-9f08ba013b has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-9f08ba013b`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-9f08ba013b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2022-09-24 01:31:56 UTC
FEDORA-2022-9f08ba013b has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.