Bug 2120066

Summary: Branding package build fail on system with country and language different from US and English.
Product: [oVirt] ovirt-engine Reporter: Abba Soungui YOUNOUSS <abba>
Component: Build.MavenAssignee: bugs <bugs>
Status: CLOSED NEXTRELEASE QA Contact: Lukas Svaty <lsvaty>
Severity: low Docs Contact:
Priority: low    
Version: ---CC: mperina
Target Milestone: ovirt-4.5.3Keywords: CodeChange, Upstream
Target Release: ---Flags: mperina: ovirt-4.5+
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-08-22 09:38:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Abba Soungui YOUNOUSS 2022-08-21 12:03:39 UTC 
Description of problem:
When you try to build ovirt-engine on a system using a language and/or country different from English and US (e.g French and Cameroon), the build of the module Branding package fails because during test phase, Maven Surefire uses OS Locale as default for getting some properties in MessageBundles, instead of en_US. 


Version-Release number of selected component (if applicable):
4.5.2

How reproducible:
Always

Steps to Reproduce:
1. Set the OS language and country to something other than English and US.
2. Follow Github documentation to deploy a development environment.
3. Launch the build of ovirt-engine.

Actual results:
The build fail with a message similar to this:

[ERROR] Failures: 
[ERROR]   BrandingThemeTest.testGetMessagesBundle:55 expected: <Login header> but was: <Login header(fr)>
[INFO] 
[ERROR] Tests run: 30, Failures: 1, Errors: 0, Skipped: 0



Expected results:
The build should consider the locale en_US as default and compile sucessfully.


Additional info:
Using JVM environment variables -Duser.country and -Duser.language doesn't solve the problem, however adding them in the argline element of the configuration section of Maven Surefire Plugin in the POM of ovirt-engine solves the problem.
Comment 1 RHEL Program Management 2022-08-22 09:38:16 UTC 
The documentation text flag should only be set after 'doc text' field is provided. Please provide the documentation text and set the flag to '?' again.