Bug 2120099

Summary:	Review Request: qsort - Quicksort implemented as a C macro
Product:	[Fedora] Fedora	Reporter:	Jonathan Wright <jonathan>
Component:	Package Review	Assignee:	Diego Herrera <dherrera>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	benson_muite, dherrera, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-11-10 00:45:21 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	201449

Description Jonathan Wright 2022-08-21 16:48:36 UTC

Spec URL: https://jonathanspw.fedorapeople.org/qsort.spec
SRPM URL: https://jonathanspw.fedorapeople.org/qsort-0.2-1.fc38.src.rpm

Description: This is a traditional Quicksort implementation which for the most part
follows Robert Sedgewick's 1978 paper. It is implemented as a C macro,
which means that comparisons can be inlined. A distinctive feature of this
implementation is that it works entirely on array indices, while actual
access to the array elements is abstracted out with the `less` and `swap`
primitives provided by the caller.

Fedora Account System Username: jonathanspw

This is in relation to https://bugzilla.redhat.com/show_bug.cgi?id=2118835 to avoid bundling qsort.h.

Comment 1 Benson Muite 2022-08-21 18:05:31 UTC

Possible update to add a functionality test:
https://copr-dist-git.fedorainfracloud.org/cgit/fed500/qsort/qsort.git/commit/?id=35632d7593c23f2767e68a11a85ac53c59fc0f59

Comment 2 Benson Muite 2022-08-21 18:16:14 UTC

More complete results:
https://download.copr.fedorainfracloud.org/results/fed500/qsort/fedora-36-x86_64/04752816-qsort/

Comment 3 Jonathan Wright 2022-08-21 18:54:22 UTC

Added bench for x86_64.  Maintaining the patches to run it on all arches is more than I'm comfortable maintaining.

Spec URL: https://jonathanspw.fedorapeople.org/qsort.spec
SRPM URL: https://jonathanspw.fedorapeople.org/qsort-0.2-1.fc38.src.rpm

Comment 4 Benson Muite 2022-08-22 05:05:15 UTC

Happy to be a co-maintainer to enable the patches to work, which probably requires someone else to review.

Comment 5 Benson Muite 2022-08-22 05:28:16 UTC

https://github.com/svpv/qsort/pull/2

Comment 6 Jonathan Wright 2022-08-22 22:34:06 UTC

I'd be happy to have you co-maintain the package.

I don't think there's any guideline preventing you from doing the review even if the intent is for you to co-maintain it?

Comment 7 Diego Herrera 2022-09-09 16:03:01 UTC

* Checking the guidelines for header libraries, the devel package must not be marked as no-arch [0]
* You should add a comment above the patch to describe the fedora specific change [1] (mjt qsort is not packaged in fedora or something)

[0] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_use_noarch_only_in_subpackages
[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_fedora_specific_or_rejected_upstream_patches

Comment 8 Package Review 2023-09-30 00:45:37 UTC

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 9 Package Review 2023-11-10 00:45:21 UTC

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.