Bug 2120462
| Summary: | Review Request: golang-github-twpayne-shell - go-shell returns a user's shell across multiple platforms | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Anthony Rabbito <hello> |
| Component: | Package Review | Assignee: | Mikel Olasagasti Uranga <mikel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | hello, mikel, package-review |
| Target Milestone: | --- | Flags: | mikel:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-10-07 02:48:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2130734 | ||
|
Description
Anthony Rabbito
2022-08-23 02:32:40 UTC
Updated spec to use `gometa -f` Spec URL: https://anthr76.fedorapeople.org/golang-github-twpayne-shell/golang-github-twpayne-shell.spec SRPM URL: https://anthr76.fedorapeople.org/golang-github-twpayne-shell/golang-github-twpayne-shell-0.3.1-1.fc37.src.rpm Spec is correct, but, is the `shell` binary required? I guess it's a simple test app, but not useful for regular users. Can you confirm? You are correct. The shell binary looks quite pointless besides testing so I have stripped it. Spec URL: https://anthr76.fedorapeople.org/golang-github-twpayne-shell/golang-github-twpayne-shell.spec SRPM URL: https://anthr76.fedorapeople.org/golang-github-twpayne-shell/golang-github-twpayne-shell-0.3.1-1.fc37.src.rpm go2rpm package: - [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [-] Binaries don't conflict with binaries already in the distribution - [x] The package complies with the Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add package to release-monitoring.org - [ ] Give go-sig privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-twpayne-shell FEDORA-2022-8e9b4df456 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8e9b4df456 FEDORA-2022-8e9b4df456 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-1536ba565d has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-1536ba565d FEDORA-2022-d25d74f528 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-d25d74f528 FEDORA-2022-d25d74f528 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-d25d74f528 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d25d74f528 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-1536ba565d has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-1536ba565d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-1536ba565d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-1536ba565d has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-d25d74f528 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. |